DOCSP-43095: Transactions #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Few things I noticed upon inspection:
- I got some relevant technical feedback on the transactions pg for PHP driver. I think using that page as a template for this page would use the most up to date and technically correct info about transactions.
- It would be best to show an example that uses the Convenient transactions API instead of the manual (core) API, unless requested by the C dbx team. This API uses the
mongoc_client_session_with_transaction()method. - The transactions example is most useful if it shows a common use case such as committing changes across multiple collections. It is a slight improvement to the example that would more closely match the use case for many users. see PHP page for an example you might want to adapt.
Let me know if you have any questions about this feedback! I'll wait to leave a more detailed review in the next round.
rustagir
approved these changes
Oct 1, 2024
adriandole
suggested changes
Oct 8, 2024
source/includes/write/transactions.c
Outdated
| mongoc_collection_t *savings = mongoc_client_get_collection (client, "sample_bank", "savings"); | ||
| mongoc_collection_t *receipts = mongoc_client_get_collection (client, "sample_bank", "receipts"); | ||
|
|
||
| char *account_id = "123456"; |
There was a problem hiding this comment.
Suggested change
| char *account_id = "123456"; | |
| const char *account_id = "123456"; |
Not recommended to define non-const string literals.
source/includes/write/transactions.c
Outdated
| // end-callback | ||
|
|
||
| int | ||
| main (int argc, char *argv[]) |
There was a problem hiding this comment.
Suggested change
| main (int argc, char *argv[]) | |
| main (void) |
Prevent unused variable warnings by skipping argc and argv in main if they are unused.
source/includes/write/transactions.c
Outdated
|
|
||
| // start-callback | ||
| bool | ||
| transaction_callback (mongoc_client_session_t *session) |
There was a problem hiding this comment.
Suggested change
| transaction_callback (mongoc_client_session_t *session) | |
| transaction_callback(mongoc_client_session_t *session, void *ctx, | |
| bson_t **reply, bson_error_t *error) | |
| { | |
| BSON_UNUSED(ctx); | |
| BSON_UNUSED(reply); |
Declaring the full callback type prevents a function casting warning and I think it's more informative.
adriandole
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43095
Staging - https://deploy-preview-59--docs-c.netlify.app/write/transactions/
Self-Review Checklist