-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-43056 Run a command #64
DOCSP-43056 Run a command #64
Conversation
✅ Deploy Preview for docs-c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -9,6 +9,7 @@ | |||
Get Started </get-started> | |||
/connect | |||
/databases-collections | |||
/run-command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[note to reviewer] This will move to the /databases-collections
section once DOCSP-4063 is merged.
.. _c-run-command: | ||
|
||
====================== | ||
Run a Database Command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[note to reviewer] Added "Database" to this title as this page will live in the /databases-collections
drawer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! A few changes and suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more suggestions, otherwise LGTM with the highlighting adjusted!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with pending comments addressed.
I highly recommend running compile on code files. I expect that can catch typos early and may ease writing examples. To compile on macOS:
$ brew install mongo-c-driver
$ clang -o run-command run-command.c $(pkg-config --libs --cflags libmongoc-1.0)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43056
Staging - https://deploy-preview-64--docs-c.netlify.app/run-command/
Self-Review Checklist