DOCSP-43533 - Version 6.9 #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rustagir
requested changes
Sep 13, 2024
source/whats-new.txt
Outdated
Comment on lines
87
to
90
| .. code-block:: javascript | ||
| :copyable: true | ||
|
|
||
| const client = new MongoClient(process.env.MONGODB_URI, { autoSelectFamily: true, autoSelectFamilyTimeout: 100 }); |
There was a problem hiding this comment.
S: not sure we use an env variable in most other places. In this instance, I think you can omit the connection string parameter altogether and the driver uses localhost 27017. Also, newline where possible to reduce the scroll
There was a problem hiding this comment.
The API docs says URL is required? I can just use a variable.
source/whats-new.txt
Outdated
| This optimization doesn't apply if you provide a transform to the ``cursor.map()`` method | ||
| before calling the ``toArray()`` method. | ||
| - Fixes mixed use of the ``cursor.next()`` method along with ``for await`` syntax. | ||
| - Fixes the ``enableUtf8Validation`` when deserializing BSON. |
There was a problem hiding this comment.
S: more info needed. is there an error?
Co-authored-by: Rea Rustagi <[email protected]>
rustagir
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43533
Staging:
Self-Review Checklist