Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-34891: Add admonition to mention users must catch errors raised by withTransaction() callback #922

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Nov 4, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-34891
Staging - https://deploy-preview-922--docs-node.netlify.app/fundamentals/transactions/#convenient-transaction-api/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Nov 4, 2024

Deploy Preview for docs-node ready!

Name Link
🔨 Latest commit 1ca4ca7
🔍 Latest deploy log https://app.netlify.com/sites/docs-node/deploys/67290665a3b65600083ed0e2
😎 Deploy Preview https://deploy-preview-922--docs-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mcmorisi mcmorisi marked this pull request as ready for review November 4, 2024 17:43
Copy link
Collaborator

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mcmorisi mcmorisi merged commit dc66c14 into mongodb:master Nov 4, 2024
5 checks passed
@mcmorisi mcmorisi deleted the DOCSP-34891-infinite-loop branch November 4, 2024 18:17
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
mcmorisi added a commit that referenced this pull request Nov 4, 2024
… by withTransaction() callback (#922)

(cherry picked from commit dc66c14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants