DOP-4549: Branches and repos in separate dropdowns in slack deploy dialog #1029
Conversation
anabellabuckvar
changed the title
|
Your feature branch infrastructure has been deployed! Your webhook URL is: https://es3go1ktj7.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build For more information on how to use this endpoint, follow these instructions. |
anabellabuckvar
force-pushed
the
DOP-4549
branch
from
e797daf to
061e849
Compare
There was a problem hiding this comment.
I'm confused at how this solves the >100 choices in the dropdown list. At first glance, it seems to actually bring the problem back? Because the inactive branches now are sorted only by their repoName rather than all the way to the bottom. I feel like I'm missing something, though!
api/handlers/slack.ts
Outdated
| //sort the options by version number | ||
| const repoOption = { | ||
| label: { | ||
| type: 'plain_text', | ||
| text: repoName, | ||
| }, | ||
| options: options.sort((branchOne, branchTwo) => { | ||
| return branchTwo.text.text |
There was a problem hiding this comment.
nit: could you move the comment down to the options line?
Fair question!! Each group can have 100 choices, so now we are only limited to 100 versions per repo as opposed to 100 versions total in the dialog. |
| options: options.sort((branchOne, branchTwo) => { | ||
| return branchTwo.text.text | ||
| .toString() | ||
| .replace(/\d+/g, (n) => +n + 100000) |
There was a problem hiding this comment.
I think we can forgo the .replace statement as I think the comparison should work as is. Here's a quick example I used:
It seems that with or without the replace, we get the same result.
There was a problem hiding this comment.
You're right for those examples! Unfortunately, when we are sorting versions like v7.18 and v7.2, if we don't use the .replace statement localeCompare will sort the versions as if v7.2 is greater than v7.18, which we don't want
There was a problem hiding this comment.
Ah, gotcha! That makes sense
api/handlers/slack.ts
Outdated
| } | ||
| return entitledBranches.sort(); | ||
| return repoOptions.sort((repoOne, repoTwo) => { |
There was a problem hiding this comment.
NIT: This can be simplified to
return repoOptions.sort((repoOne, repoTwo) => repoOne.label.text.localeCompare(repoTwo.label.text);
Stories/Links:
DOP-4549
Notes
This PR:
Example Build
README updates