PHPORM-238 Add support for withCount and other aggregations
#3182
+334
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
commented
Oct 17, 2024
| @@ -556,6 +557,8 @@ public function generateCacheKey() | |||
| /** @return ($function is null ? AggregationBuilder : mixed) */ | |||
| public function aggregate($function = null, $columns = ['*']) | |||
| { | |||
| assert(is_array($columns), new TypeError(sprintf('Argument #2 ($columns) must be of type array, %s given', get_debug_type($columns)))); | |||
There was a problem hiding this comment.
We cannot add the type to the argument as it's missing in the parent method. When the value is invalid here, the error comes very late in Query\Builder::toMQL.
GromNaN
commented
Oct 17, 2024
src/Query/Builder.php
Outdated
Comment on lines
602
to
605
| // When the aggregation is per group, we return the results as is. | ||
| if ($this->groups) { | ||
| return $results; | ||
| } |
There was a problem hiding this comment.
Trying to support this feature in Laravel, so that withCount on hybrid relations could work.
There was a problem hiding this comment.
Can you just not add withCount on hybrid relations, its a blocker. Also a suggestion It would be better for hybrid to be a separate package instead of being integrated into laravel-mongodb if that could ease the maintenance and focus for other mongodb eloquent methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-238
Implement this feature from Laravel: https://laravel.com/docs/11.x/eloquent-relationships#counting-related-models
Counting relations with SQL is done using a subquery. For MongoDB, there is 2 ways:
$groupby foreign key.$lookupto load references and count them. The process would be similar for embedded relations (without the$lookup). But this doesn't work with hybrid relations.Checklist