fix: allow array getters to return non-arrays #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DesignByOnyx
force-pushed
the
37-fix-array-getter-return-non-array
branch
from
cc85664 to
db1fb91
Compare
|
I can report that this fix got all of our tests passing again. We were previously on 0.4.0 (sorry about that). I have the bandwidth to make any additional changes to get this merged, and I can test it against a fairly large 10 year old project being deployed to very large companies. |
|
I pushed fix in 5e0541c, this PR had a bunch of merge conflicts from subsequent PRs. I'm sorry I closed without merging, but I will make a note of your contribution in the changelog. And I'm very sorry for the delay in merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Array getters should be allowed to return non-arrays.
This fixes #37 and #36