Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug 2fa redirect to unallowed method #6703

Merged
merged 6 commits into from
Nov 5, 2023
Merged

fix: bug 2fa redirect to unallowed method #6703

merged 6 commits into from
Nov 5, 2023

Conversation

efturtle
Copy link

@efturtle efturtle commented Jun 20, 2023 •
edited
Loading

Fix #5916

This happens after mistakenly entering a wrong 2fa code at first, then retrying and entering a correct 2fa code.

Bug cause by an input, the value of the input changes to 'validate2fa'(after error) which is then taken to make a GET request.
validate2fa is a post request and users where getting a 405 method not allowed screen

  • I changed the input value to a static 'dashboard' string

Checklist

Before submitting the PR

  • Read the CONTRIBUTING document before submitting your PR.
  • If the PR is related to an issue or fix one, don't forget to indicate it.
  • [] Create your PR as draft if it is not final yet. Mark it as ready... when it’s ready. Otherwise the PR will be considered complete and rejected if it's not working.

General checks

  • Make sure that the change you propose is the smallest possible.
  • The name of the PR should follow the conventional commits guideline that the project follows.

@efturtle
fix: bug 2fa redirect to unallowed method
03217d5 
Bug cause by an input value that tries to do a get request to a post route.

after a failure to verify the 2fa code the url in navbar changes to validate2fa which is a post route.

- set the input value to static string 'dashboard'
@CLAassistant
Copy link

CLAassistant commented Jun 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@efturtle efturtle changed the title fix: bug 2fa redirect to unallowed method (#5916) fix: bug 2fa redirect to unallowed method Jun 20, 2023
@efturtle efturtle marked this pull request as ready for review June 23, 2023 19:55
@iam-subho
Copy link

can i work on this issue or this issue is resolved???

@efturtle
Copy link
Author

efturtle commented Oct 9, 2023

I created a PR but has not been aproved

asbiin
asbiin approved these changes Nov 5, 2023
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
resources/views/auth/validate2fa.blade.php Outdated Show resolved Hide resolved
@asbiin asbiin added the reviewed label Nov 5, 2023
@asbiin asbiin merged commit 91cf915 into monicahq:4.x Nov 5, 2023
19 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asbiin asbiin asbiin approved these changes

Assignees
No one assigned
Labels
reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct 2FA code after wrong 2FA code results in 405
4 participants
@efturtle @CLAassistant @iam-subho @asbiin