fix: correct boolean values and exclude archived results from search #7436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes to API search results:
is_active
andis_dead
values are accurate, instead of always being cast tofalse
because they’re absent from the$return_from_search
set and never passed along.is_active = true
so that archived contacts are excluded.I was surprised to find archived contacts in the results, but I can understand if item 2 is too opinionated since there are otherwise no other filters applied to that search. No problem removing and doing that client side if you’d rather!
Tested locally to confirm both work as expected.