Skip to content

Commit

Permalink
[app] Fixed opening external links
Browse files Browse the repository at this point in the history
  • Loading branch information
monich committed Nov 6, 2021
1 parent f79b2f1 commit 60f2b1e
Showing 1 changed file with 15 additions and 12 deletions.
27 changes: 15 additions & 12 deletions app/qml/BooksLinkMenu.qml
Original file line number Diff line number Diff line change
@@ -1,21 +1,22 @@
/*
Copyright (C) 2016 Jolla Ltd.
Contact: Slava Monich <[email protected]>
Copyright (C) 2016-2021 Jolla Ltd.
Copyright (C) 2016-2021 Slava Monich <[email protected]>
You may use this file under the terms of BSD license as follows:
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions
are met:
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
* Neither the name of Jolla Ltd nor the names of its contributors
may be used to endorse or promote products derived from this software
without specific prior written permission.
1. Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
2. Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer
in the documentation and/or other materials provided with the
distribution.
3. Neither the names of the copyright holders nor the names of its
contributors may be used to endorse or promote products derived
from this software without specific prior written permission.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
Expand All @@ -35,6 +36,7 @@ import Sailfish.Silica 1.0

Rectangle {
id: root

visible: opacity > 0.0
opacity: 0.0
width: parent.width
Expand All @@ -60,6 +62,7 @@ Rectangle {

Label {
id: title

anchors.horizontalCenter: parent.horizontalCenter
//: External link menu title
//% "Link"
Expand Down Expand Up @@ -113,9 +116,9 @@ Rectangle {
//% "Open in browser"
text: qsTrId("harbour-books-book-browser_link-open_in_browser")
onClicked: {
console.log("opening", root.url)
console.log("opening", linkLabel.text)
root.hide()
Qt.openUrlExternally(root.url)
Qt.openUrlExternally(linkLabel.text)
}
}

Expand Down

0 comments on commit 60f2b1e

Please sign in to comment.