impr(SEO): Semantic HTML (borisnezlobin) #4859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisnezlobin
changed the title
Miodec
requested changes
Dec 14, 2023
| <h2> | ||
| </section> | ||
| <section> | ||
| <h1 class="bigtitle">about</h1> |
There was a problem hiding this comment.
Use h2 here, then you can remove the bigtitle class
| <div class="section"> | ||
| </p> | ||
| </section> | ||
| <section> | ||
| <div class="title">word set</div> |
There was a problem hiding this comment.
Use h3, then remove the title class
There was a problem hiding this comment.
Also use h3 everywhere where you already used h2
|
Will do! |
borisnezlobin
force-pushed
the
semantic-html
branch
from
ddca5ce to
b974063
Compare
|
Everywhere else you mean other pages? |
|
yep! |
|
Yeah sure |
|
hi @borisnezlobin, |
|
Will do! I have finals this week, but will be able to work on this later this week + next |
|
This PR is stale. Please trigger a re-run of the PR check action. |
|
This PR is stale. Please trigger a re-run of the PR check action. |
2 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the HTML to be more semantic (e.g., changing
<div class="section">to just<section>)This PR currently only changes one page (
/about) in order to get progress feedback before changes are made to everything.Checks
No visual changes
Closes #4857