Remove code for unimplemented templates #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrkdan
commented
Dec 18, 2023
| @@ -1,5 +1,5 @@ | |||
| module.exports = { | |||
| plugins: ["@typescript-eslint", "solid"], | |||
| plugins: ["@typescript-eslint", "react"], | |||
There was a problem hiding this comment.
The react/base eslint plugin was not changed from solid to react, so I'm changing it here.
There was a problem hiding this comment.
I've decided to remove the unused options for now to reduce code clutter.
When we re-implement them in the future, we can just refer to this commit :)
jinmayamashita
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
console.log())npm run test:cli)npm run test:modules)npm run e2e)Description
Context
In order to reduce code clutter, I've removed the currently unused code templates for
react-standard,solid, andvue. Additionally, I've removedSolidfrom the Javascript library CLI option list.Before
solidis displayed as one of the options for Javascript libraries when running thecreate-codescommand.After
solidis no longer displayed as one of the options for Javasciprt libraries.N/A
Notes