Merge pull request kubernetes-sigs#4351 from monteiro-renato/patch-13

🐛 fix: (helm/alpha-v1): Fix rendered value for app.kubernetes.io/name
monteiro-renato · Nov 20, 2024 · 5d9d4ac · 5d9d4ac
2 parents 75e906d + 48971b4
commit 5d9d4ac
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...plugins/optional/helm/v1alpha/scaffolds/internal/templates/chart-templates/helpers_tpl.go b/...plugins/optional/helm/v1alpha/scaffolds/internal/templates/chart-templates/helpers_tpl.go
@@ -47,7 +47,7 @@ func (f *HelmHelpers) SetTemplateDefaults() error {
 const helmHelpersTemplate = `{{` + "`" + `{{- define "chart.name" -}}` + "`" + `}}
 {{` + "`" + `{{- if .Chart }}` + "`" + `}}
   {{` + "`" + `{{- if .Chart.Name }}` + "`" + `}}
-    {{` + "`" + `{{ .Chart.Name | trunc 63 | trimSuffix "-" }}` + "`" + `}}
+    {{` + "`" + `{{- .Chart.Name | trunc 63 | trimSuffix "-" }}` + "`" + `}}
   {{` + "`" + `{{- else if .Values.nameOverride }}` + "`" + `}}
     {{` + "`" + `{{ .Values.nameOverride | trunc 63 | trimSuffix "-" }}` + "`" + `}}
   {{` + "`" + `{{- else }}` + "`" + `}}

diff --git a/testdata/project-v4-with-plugins/dist/chart/templates/_helpers.tpl b/testdata/project-v4-with-plugins/dist/chart/templates/_helpers.tpl
@@ -1,7 +1,7 @@
 {{- define "chart.name" -}}
 {{- if .Chart }}
   {{- if .Chart.Name }}
-    {{ .Chart.Name | trunc 63 | trimSuffix "-" }}
+    {{- .Chart.Name | trunc 63 | trimSuffix "-" }}
   {{- else if .Values.nameOverride }}
     {{ .Values.nameOverride | trunc 63 | trimSuffix "-" }}
   {{- else }}