[fix] set timeout to invoke callback function after the model is updated

monterail · May 26, 2014 · f472c4f · f472c4f
1 parent 11d0358
commit f472c4f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/build/angular-date-range-picker.js b/build/angular-date-range-picker.js
diff --git a/build/angular-date-range-picker.min.js b/build/angular-date-range-picker.min.js
diff --git a/src/angular-date-range-picker.coffee b/src/angular-date-range-picker.coffee
@@ -1,6 +1,6 @@
 angular.module "dateRangePicker", ['pasvaz.bindonce']
 
-angular.module("dateRangePicker").directive "dateRangePicker", ["$compile", ($compile) ->
+angular.module("dateRangePicker").directive "dateRangePicker", ["$compile", "$timeout", ($compile, $timeout) ->
   # constants
   pickerTemplate = """
   <div ng-show="visible" class="angular-date-range-picker__picker" ng-click="handlePickerClick($event)" ng-class="{'angular-date-range-picker--ranged': showRanged }">
@@ -208,7 +208,7 @@ angular.module("dateRangePicker").directive "dateRangePicker", ["$compile", ($co
     $scope.ok = ($event) ->
       $event?.stopPropagation?()
       $scope.model = $scope.selection
-      $scope.callback() if $scope.callback
+      $timeout -> $scope.callback() if $scope.callback
       $scope.hide()
 
     $scope.select = (day, $event) ->

diff --git a/test/index.html b/test/index.html
@@ -16,8 +16,8 @@
         $scope.range2 = moment().range("2012-11-15", "2012-12-25")
       }
 
-      $scope.fireCallback = function() {
-        console.log('callback fired!');
+      $scope.fireCallback = function(range) {
+        console.log(range);
       };
 
       $scope.date = null
@@ -37,7 +37,7 @@
       <h1>Date range picker</h1>
       <date-range-picker ng-model="range"></date-range-picker>
       <pre>{{ range.start.toDate() }} - {{ range.end.toDate() }}</pre>
-      <date-range-picker ng-model="range2" ranged="true" callback="fireCallback()"></date-range-picker>
+      <date-range-picker ng-model="range2" ranged="true" callback="fireCallback(range2)"></date-range-picker>
       <button ng-click="change()">Change</button>
     </div>
     <div>