Skip to content

Commit

Permalink
Review additions: Add Behat tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@abias
abias committed Dec 29, 2024
1 parent d4a7e3b commit 6ad46c7
Show file tree
Hide file tree
Showing 3 changed files with 81 additions and 27 deletions.
9 changes: 4 additions & 5 deletions lib.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -807,14 +807,13 @@ function theme_boost_union_alter_css_urls(&$urls) {
// Require flavours library.
require_once($CFG->dirroot . '/theme/boost_union/flavours/flavourslib.php');

// In the original code, Bas commented: "No CSS switch during behat runs, or it will take ages to run a scenario."
// While there is a reason for this in Bas' context, We do not have to care about this as we do only change the URL
// if a flavour applies and in these cases, the CSS must be switched in any case.

// If any flavour applies to this page.
$flavour = theme_boost_union_get_flavour_which_applies();
if ($flavour != null) {
if (defined('BEHAT_SITE_RUNNING') && BEHAT_SITE_RUNNING) {
// No CSS switch during behat runs, or it will take ages to run a scenario.
return;
}

// Iterate over the CSS URLs.
foreach (array_keys($urls) as $i) {
// If we have a moodle_url object.
Expand Down
76 changes: 72 additions & 4 deletions tests/behat/theme_boost_union_flavourssettings_look.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,17 +129,85 @@ Feature: Configuring the theme_boost_union plugin on the "Flavours" page, applyi
# Scenario: Flavours: Background image - Do not upload a background image (with a global background image being served properly)

@javascript
Scenario: Flavours: Custom SCSS - Add custom SCSS to the page
Scenario: Flavours: Brand color - Set the brand color
Given the following "categories" exist:
| name | category | idnumber |
| Cat 1 | 0 | CAT1 |
And the following "courses" exist:
| fullname | shortname | category |
| Course 1 | C1 | CAT1 |
When I log in as "admin"
And I navigate to "Appearance > Boost Union > Flavours" in site administration
And I click on "Create flavour" "button"
And I should see "Create flavour" in the "#page-header h1" "css_element"
And I expand all fieldsets
And I set the field "Title" to "My shiny new flavour"
# We add a small CSS snippet to the flavour which hides the heading in the page header.
# This is just to make it easy to detect the effect of this flavour.
And I set the field "look_brandcolor" to "#FF0000"
And I select "Yes" from the "Apply to course categories" singleselect
And I click on ".form-autocomplete-downarrow" "css_element" in the "#fitem_id_applytocategories_ids" "css_element"
And I click on "Cat 1" item in the autocomplete list
And I press the escape key
And I click on "Save changes" "button"
And the following "activities" exist:
| activity | name | intro | course |
| label | Label one | <span class="mytesttext text-primary">My test text</span> | C1 |
When I log in as "admin"
And I am on "Course 1" course homepage
And I should see "My test text"
Then DOM element ".mytesttext" should have computed style "color" "rgb(255, 0, 0)"

@javascript
Scenario Outline: Flavours: Bootstrap colors - Set the Bootstrap colors
Given the following "categories" exist:
| name | category | idnumber |
| Cat 1 | 0 | CAT1 |
And the following "courses" exist:
| fullname | shortname | category |
| Course 1 | C1 | CAT1 |
When I log in as "admin"
And I navigate to "Appearance > Boost Union > Flavours" in site administration
And I click on "Create flavour" "button"
And I should see "Create flavour" in the "#page-header h1" "css_element"
And I expand all fieldsets
And I set the field "Title" to "My shiny new flavour"
And I set the field "look_bootstrapcolor<type>" to "<colorhex>"
And I select "Yes" from the "Apply to course categories" singleselect
And I click on ".form-autocomplete-downarrow" "css_element" in the "#fitem_id_applytocategories_ids" "css_element"
And I click on "Cat 1" item in the autocomplete list
And I press the escape key
And I click on "Save changes" "button"
And the following "activities" exist:
| activity | name | intro | course |
| label | Label one | <span class="mytesttext text-<type>">My test text</span> | C1 |
When I log in as "admin"
And I am on "Course 1" course homepage
And I should see "My test text"
Then DOM element ".mytesttext" should have computed style "color" "<colorrgb>"

Examples:
| type | colorhex | colorrgb |
| success | #FF0000 | rgb(255, 0, 0) |
| info | #00FF00 | rgb(0, 255, 0) |
| warning | #0000FF | rgb(0, 0, 255) |
| danger | #FFFF00 | rgb(255, 255, 0) |

@javascript
Scenario: Flavours: Raw (initial) SCSS - Add custom SCSS to the page
When I log in as "admin"
And I navigate to "Appearance > Boost Union > Flavours" in site administration
And I click on "Create flavour" "button"
And I should see "Create flavour" in the "#page-header h1" "css_element"
And I expand all fieldsets
And I set the field "Title" to "My shiny new flavour"
# We add a SCSS variable and a small SCSS snippet to the flavour which hides the heading in the page header.
# This is just to make it easy to detect the effect of this flavour and to verify that SCSS is compiled correctly.
And I set the field "Raw initial SCSS" to multiline:
"""
$myvariable: none;
"""
And I set the field "Raw SCSS" to multiline:
"""
#page-header h1 { display: none; }
#page-header h1 { display: $myvariable; }
"""
And I click on "Save changes" "button"
And I should see "Flavours" in the "#region-main h2" "css_element"
Expand Down
23 changes: 5 additions & 18 deletions tests/behat/theme_boost_union_looksettings_scss.feature
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,33 +10,20 @@ Feature: Configuring the theme_boost_union plugin for the "SCSS" tab on the "Loo
| Course 1 | C1 |

@javascript
Scenario: Setting: Raw initial SCSS - Add custom SCSS to the theme
Scenario: Setting: Raw (initial) SCSS - Add custom SCSS to the theme
When I log in as "admin"
And Behat debugging is disabled
And I navigate to "Appearance > Boost Union > Look" in site administration
And I click on "SCSS" "link" in the "#adminsettings .nav-tabs" "css_element"
# We add a small CSS snippet to the page which hides the heading in the page header.
# This is just to make it easy to detect the effect of this custom SCSS code.
# We add a SCSS variable and a small SCSS snippet to the page which hides the heading in the page header.
# This is just to make it easy to detect the effect of this custom SCSS code and to verify that SCSS is compiled correctly.
And I set the field "Raw initial SCSS" to multiline:
"""
#page-header h1 { display: none; }
$myvariable: none;
"""
And I press "Save changes"
And Behat debugging is enabled
And I am on "Course 1" course homepage
Then I should not see "Course 1" in the "#page-header .page-header-headings" "css_element"

@javascript
Scenario: Setting: Raw SCSS - Add custom SCSS to the theme
When I log in as "admin"
And Behat debugging is disabled
And I navigate to "Appearance > Boost Union > Look" in site administration
And I click on "SCSS" "link" in the "#adminsettings .nav-tabs" "css_element"
# We add a small CSS snippet to the page which hides the heading in the page header.
# This is just to make it easy to detect the effect of this custom SCSS code.
And I set the field "Raw SCSS" to multiline:
"""
#page-header h1 { display: none; }
#page-header h1 { display: $myvariable; }
"""
And I press "Save changes"
And Behat debugging is enabled
Expand Down

0 comments on commit 6ad46c7

Please sign in to comment.