Improvement: Add a direct 'view course' icon on the course management pages, solves #129.

[abias]

No description provided.

[lucaboesch]

Oh my, I'm sorry to rain on the parade. It's probably also due to time we let pass to develop this. But I just noticed we call that 'thing' all sort of names: "link", "icon", "button".
That's no good.
We should stick to something and then call it the same way throughout everything (also renaming the Issue title and Pull request title).
Now when there would also be a possibility to add the 'thing' "action", I would propose to go for 'icon'.
So the Site administration setting would become '"Show view course icon" theme_boost_union | showviewcourseiconincoursemgnt'
Also in the descriptive text there could be mentioned the other two-click way to go to course view "By default, on the course management page, Moodle requires you to open the course details before you can view the course. By enabling this setting, you can add a 'View course' icon directly to the category listing on the course management page."
→
"By default, on the course management page, Moodle requires you to either open the course details or to pass through the course settings before you can click an additional UI element to view the course. By enabling this setting, you can add a 'View course' icon directly to the category listing on the course management page."

Very nit-picky but probably worth it.

[lucaboesch]

Also, what about trying to use the course icon (pretend it's the link color)?

[abias]

Hey @lucaboesch ,

thank you very much for your insights!
I fully agree that we should use a consistent terminology. I have changed the patch to use "icon" consistently.

Regarding your proposal about the icon, I think I can't change this icon and the mortarboard icon is perfectly fine.
If you look at the patch, you will see that it just uses the pix_icon i/course. And this icon is mapped to fa-graduation-cap on https://github.com/moodle/moodle/blob/master/lib/classes/output/icon_system_fontawesome.php#L217. The three-dots-circle icon is an invention of previous Moodle versions and simply does not exist in font awesome.

I have pushed an updated patch and would then merge the PR as soon as the tests have passed again.

Cheers,
Alex