Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Add background color to OAuth2 login button, solves #473. #478

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

wa-bea
Copy link
Collaborator

@wa-bea wa-bea commented Nov 23, 2023

OAuth2 login button was transparent.
Adding btn-secondary class to this button solves the missing background color problem.

Before:

before

After:

after

Copy link
Member

@abias abias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @wa-bea for providing this fix!
I have just added a review commit which adds a modification note to the overridden mustache template and will merge the PR now.

@abias abias merged commit c7f24d1 into moodle-an-hochschulen:master Nov 23, 2023
6 checks passed
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants