Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add frontpage slider functionality, solves #162 #523

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

abias
Copy link
Member

@abias abias commented Dec 31, 2023

This PR replaces PR #391 as I was not able to push review changes to Matthias' PR branch

lucaboesch
lucaboesch previously approved these changes Dec 31, 2023
Copy link
Collaborator

@lucaboesch lucaboesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some minor things but other than that, this is good to go.
Please merge, @abias.

@abias
Copy link
Member Author

abias commented Dec 31, 2023

Thank you very much, Luca, for having a look at this patch.
I have fixed the glitches which you mentioned and will merge the PR now.

@abias abias merged commit b2ca083 into master Dec 31, 2023
@abias abias deleted the feature-162-final branch December 31, 2023 11:30
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this pull request Aug 26, 2024
…en/feature-162-final

Feature: Add frontpage slider functionality, solves moodle-an-hochschulen#162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants