Check USE_SELVERSION for true or false #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value is a boolean cast to string in Groovy. The string is never empty.
|
Thanks Andrew, it makes sense to check if the USE_SELVERSION is not true |
|
Sorry, but... doesn't the check need to be the opposite? We want to use the selenium (upstream) version when the env var is not "false|empty" (aka, when it's set), isn't it? With current patch we continue using the upstream selenium all the time, because it's getting a "false", if I understood the regression correctly. |
stronk7
added a commit
to stronk7/moodle-ci-runner
that referenced
this pull request
Feb 22, 2024
While it doesn't support every single case, now, any integer > 0 and any case-insenstive "true" string or bool will use the upstream selenium images. That should be enough for this case, don't expect other "truthy" values to be used. This improves (and partially reverts) moodlehq#115.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This value is a boolean cast to string in Groovy. The string is never empty.