Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to run bisect sessions to the phpunit job #117

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented Apr 12, 2024

If GOOD_COMMIT and BAD_COMMIT are set, then a phpunit bisect happens between the 2 commits, using the exact configuration provided (filter, database, ... everything).

@stronk7 stronk7 changed the title Add support to run bisect sections to the phpunit job Add support to run bisect sessions to the phpunit job Apr 12, 2024
@stronk7 stronk7 force-pushed the bisect_phpunit branch 3 times, most recently from ea89d64 to 7716cac Compare April 12, 2024 10:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 62.83%. Comparing base (9b46db1) to head (7e84185).

Files Patch % Lines
runner/main/jobtypes/phpunit/phpunit.sh 76.92% 15 Missing ⚠️
.../main/modules/moodle-core-copy/moodle-core-copy.sh 62.50% 3 Missing ⚠️
runner/main/modules/git/git.sh 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   61.76%   62.83%   +1.06%     
==========================================
  Files          38       38              
  Lines        1292     1348      +56     
==========================================
+ Hits          798      847      +49     
- Misses        494      501       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7
Copy link
Member Author

stronk7 commented Apr 12, 2024

This should be ready now, tests say so. Current jobs shouldn't be affected at all.

Once merged, will apply some changes to nightlyjobs & CIs to support the new env variables.

@stronk7 stronk7 marked this pull request as ready for review April 12, 2024 13:29
@stronk7 stronk7 self-assigned this Apr 12, 2024
@stronk7 stronk7 marked this pull request as draft April 12, 2024 14:44
@stronk7
Copy link
Member Author

stronk7 commented Apr 12, 2024

Grrr, back to draft. My latest refactor has broken something in regular phpunit runs, thanks unit tests! Investigating…

stronk7 added 2 commits April 12, 2024 17:15
If GOOD_COMMIT and BAD_COMMIT are set, then a phpunit
bisect happens between the 2 commits, using the exact
configuration provided (filter, database, ... everything).
@stronk7 stronk7 marked this pull request as ready for review April 12, 2024 16:08
@stronk7 stronk7 merged commit eee5867 into moodlehq:main Apr 12, 2024
6 checks passed
@stronk7 stronk7 deleted the bisect_phpunit branch April 12, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants