Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to latest Selenium + Chrome + Firefox versions #87

Open
wants to merge 2 commits into
base: old
Choose a base branch
from
Open

Switch to latest Selenium + Chrome + Firefox versions #87

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41a829a
Allow selenium version to be specified
andrewnicols Oct 26, 2022
2b144de
Switch to Selenium 4 images
andrewnicols Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions runner/master/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ export PLUGINSTOINSTALL="${PLUGINSTOINSTALL:-}"
# Plugin folder where the plugins to install will be downloaded.
export PLUGINSDIR="${PLUGINSDIR:-${WORKSPACE}/plugins}"

# Select image versions for Firefox and Chrome
SELVERSION="${SELVERSION:-4}"
SELCHROMEIMAGE="${SELIMAGE:-selenium/standalone-chrome:${SELVERSION}}"
SELFIREFOXIMAGE="${SELIMAGE:-selenium/standalone-firefox:${SELVERSION}}"

mkdir -p "${PLUGINSDIR}"
if [ -n "$PLUGINSTOINSTALL" ];
then
Expand Down Expand Up @@ -257,6 +262,9 @@ echo "== MOBILE_VERSION: ${MOBILE_VERSION}"
echo "== PLUGINSTOINSTALL: ${PLUGINSTOINSTALL}"
echo "== TESTSUITE: ${TESTSUITE}"
echo "== Environment: ${ENVIROPATH}"
echo "== Selenium version: ${SELVERSION}"
echo "== Chrome image: ${SELCHROMEIMAGE}"
echo "== Firefox image: ${SELFIREFOXIMAGE}"
echo "============================================================================"

# Setup the image cleanup.
Expand Down Expand Up @@ -671,19 +679,6 @@ then
SHMMAP="--shm-size=2g"

HASSELENIUM=1
SELVERSION="3.141.59"
# We are going brave here and go back to unpinned chrome version, because staying with
# the old Chrome 79 version (3.141.59-zinc) is making things really harder and harder.
# We are aware that, for headed runs, there are some zero-size errors still not fixed,
# but headless ones should run ok. For reference, the problems we are aware are being
# tracked (as of 14 Sep 2021) @:
# - MDL-71108 : zero-size
# - MDL-72306 : feedback
SELCHROMEIMAGE="selenium/standalone-chrome:${SELVERSION}"
SELFIREFOXIMAGE="selenium/standalone-firefox:${SELVERSION}"

# Temporarily switching to custom image to include our bugfix for zero size failures.
SELCHROMEIMAGE="moodlehq/selenium-standalone-chrome:96.0-moodlehq"

# Newer versions of Firefox do not allow Marionette to be disabled.
# Version 47.0.1 is the latest version of Firefox we can support when Marionette is disabled.
Expand Down