update readmes

moonflare · Feb 23, 2023 · 8d5ac03 · 8d5ac03
1 parent 36d93a4
commit 8d5ac03
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 4 deletions.
diff --git a/packages/deno/packages/plugin-dataloader/README.md b/packages/deno/packages/plugin-dataloader/README.md
@@ -306,7 +306,7 @@ const UserNode = builder.loadableNode('UserNode', {
   id: {
     resolve: (user) => user.id,
   },
-  // For loadable objects we always need to include an isTypeOf check
+  // For loadable nodes, we need to include an isTypeOf check if the first arg is a string
   isTypeOf: (obj) => obj instanceof User,
   load: (ids: string[], context: ContextType) => context.loadUsersById(ids),
   fields: (t) => ({}),

diff --git a/packages/deno/packages/plugin-dataloader/schema-builder.ts b/packages/deno/packages/plugin-dataloader/schema-builder.ts
diff --git a/packages/plugin-dataloader/README.md b/packages/plugin-dataloader/README.md
@@ -306,7 +306,7 @@ const UserNode = builder.loadableNode('UserNode', {
   id: {
     resolve: (user) => user.id,
   },
-  // For loadable objects we always need to include an isTypeOf check
+  // For loadable nodes, we need to include an isTypeOf check if the first arg is a string
   isTypeOf: (obj) => obj instanceof User,
   load: (ids: string[], context: ContextType) => context.loadUsersById(ids),
   fields: (t) => ({}),