fix duplicate interfaces when building schema multiple times

moonflare · Mar 1, 2023 · f225955 · f225955
1 parent 35f5c58
commit f225955
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/eighty-feet-sparkle.md b/.changeset/eighty-feet-sparkle.md
@@ -0,0 +1,5 @@
+---
+'@pothos/core': patch
+---
+
+Fix duplicate interfaces when building a schema multiple times
diff --git a/packages/core/src/config-store.ts b/packages/core/src/config-store.ts
@@ -443,8 +443,12 @@ export default class ConfigStore<Types extends SchemaTypes> {
     this.pending = false;
 
     const fns = this.addFieldFns;
+    const interfaces = this.pendingInterfaces;
+    const unions = this.pendingUnionTypes;
 
     this.addFieldFns = [];
+    this.pendingInterfaces = new Map();
+    this.pendingUnionTypes = new Map();
 
     fns.forEach((fn) => void fn());
 
@@ -456,13 +460,13 @@ export default class ConfigStore<Types extends SchemaTypes> {
       );
     }
 
-    for (const [typeName, unionFns] of this.pendingUnionTypes) {
+    for (const [typeName, unionFns] of unions) {
       for (const fn of unionFns) {
         this.addUnionTypes(typeName, fn);
       }
     }
 
-    for (const [typeName, interfacesFns] of this.pendingInterfaces) {
+    for (const [typeName, interfacesFns] of interfaces) {
       for (const fn of interfacesFns) {
         this.addInterfaces(typeName, fn);
       }