Skip to content

Commit

Permalink
remove trackResolver from sentry tracing docs
Browse files Browse the repository at this point in the history
  • Loading branch information
hayes committed Feb 17, 2023
1 parent 326bd04 commit fe8ef17
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 18 deletions.
8 changes: 1 addition & 7 deletions packages/plugin-tracing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -767,13 +767,7 @@ import { schema } from './schema';

const yoga = createYoga({
schema,
plugins: [
useSentry({
// Disable resolver tracking since this is covered by the pothos tracing plugin
// If all resolvers are being traced, you could use the Sentry envelop plug instead of the pothos tracing plugin
trackResolvers: false,
}),
],
plugins: [useSentry({})],
});

const server = createServer(yoga);
Expand Down
16 changes: 5 additions & 11 deletions website/pages/docs/plugins/tracing.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ slightly different.
// eslint-disable-next-line simple-import-sort/imports
import newrelic from 'newrelic'; // newrelic must be imported first
import { print } from 'graphql';
import { createYoga, Plugin } from 'graphql-yoga'
import { createYoga, Plugin } from 'graphql-yoga';
import { createServer } from 'node:http';
import { AttributeNames } from '@pothos/tracing-newrelic';
import { schema } from './schema';
Expand Down Expand Up @@ -648,7 +648,7 @@ Envelop has it's own plugin for newrelic that can be combined with the tracing p
```ts
import { useNewRelic } from '@envelop/newrelic';
import { createYoga } from 'graphql-yoga'
import { createYoga } from 'graphql-yoga';
import { createServer } from 'node:http';
import { schema } from './schema';

Expand Down Expand Up @@ -713,7 +713,7 @@ slightly different.
```ts
import '@sentry/tracing';
import { print } from 'graphql';
import { createYoga, Plugin } from 'graphql-yoga'
import { createYoga, Plugin } from 'graphql-yoga';
import { createServer } from 'node:http';
import { AttributeNames } from '@pothos/tracing-sentry';
import * as Sentry from '@sentry/node';
Expand Down Expand Up @@ -765,19 +765,13 @@ Envelop has it's own plugin for Sentry that can be combined with the tracing plu
```ts
import { useSentry } from '@envelop/sentry';
import { createYoga } from 'graphql-yoga'
import { createYoga } from 'graphql-yoga';
import { createServer } from 'node:http';
import { schema } from './schema';

const yoga = createYoga({
schema,
plugins: [
useSentry({
// Disable resolver tracking since this is covered by the pothos tracing plugin
// If all resolvers are being traced, you could use the Sentry envelop plug instead of the pothos tracing plugin
trackResolvers: false,
}),
],
plugins: [useSentry({})],
});

const server = createServer(yoga);
Expand Down

0 comments on commit fe8ef17

Please sign in to comment.