OS compatibility improvements #1121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the APK size impact of pulling in the AndroidX support libraries? |
TacoTheDank
force-pushed
the
osCompatibility
branch
from
bd90c2b
to
6b07fe4
Compare
|
For some reason I get an NDK error when trying to build (so I cannot test for myself), but I can say that the increase is likely negligible. With minify enabled, it would probably be around 250-500 KB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit
2nd commit
3rd commit
FLAG_LOW_LATENCYisn't available on L. It was introduced in API 24 and deprecated two versions later (in classic Android fashion). Anyway, I reworked the audio code so thatFLAG_LOW_LATENCYis only applied on N through N_MR1, and O and above only uses the new method (previously the new method was being applied alongside the deprecated flag, which was duplicate functionality and didn't make much sense).