Make Sub::Defer changes work with modules that have unused type declarations #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4, RT#120129)" This reverts commit c8f752e.
This is to maintain compatibility with modules that declare types but never use them. In 0.49, this could cause an exception if Sub::Defer::undefer_all was called.
oschwald
force-pushed
the
greg/autarch/more-sub-defer
branch
from
3fbc89a
to
e20a83e
Compare
|
The heisenfailure appears to be related to @autarch's commit. I am not entirely certain what is going on there. I could drop that commit if no one objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://rt.cpan.org/Ticket/Display.html?id=119534
This reverts the revert of #5 and includes #6.