Merge pull request #1480 from adamdecaf/fix-issue1170

fix: verify ACK and ATX amounts are zero

batch.go

@@ -1069,6 +1069,14 @@ func (batch *Batch) ValidAmountForCodes(entry *EntryDetail) error {
 			if batch.validateOpts != nil && batch.validateOpts.AllowZeroEntryAmount {
 				return nil
 			}
+
+			switch batch.Header.StandardEntryClassCode {
+			case ACK, ATX:
+				if entry.TransactionCode == CheckingZeroDollarRemittanceCredit || entry.TransactionCode == SavingsZeroDollarRemittanceCredit {
+					return nil
+				}
+			}
+
 			return fieldError("Amount", ErrBatchAmountZero, entry.Amount)
 		}
 	}

batchACK.go

@@ -61,9 +61,9 @@ func (batch *BatchACK) Validate() error {
 			return batch.Error("TransactionCode", ErrBatchTransactionCode, entry.TransactionCode)
 		}
 		// // Verify the Amount is valid for SEC code and TransactionCode
-		// if err := batch.ValidAmountForCodes(entry); err != nil { // TODO(adam): https://github.com/moov-io/ach/issues/1170
-		// 	return err
-		// }
+		if err := batch.ValidAmountForCodes(entry); err != nil {
+			return err
+		}
 		// Verify the TransactionCode is valid for a ServiceClassCode
 		if err := batch.ValidTranCodeForServiceClassCode(entry); err != nil {
 			return err

batchATX.go

@@ -77,10 +77,10 @@ func (batch *BatchATX) Validate() error {
 		if len(entry.Addenda05) != addendaRecords {
 			return batch.Error("AddendaCount", NewErrBatchExpectedAddendaCount(len(entry.Addenda05), addendaRecords))
 		}
-		// // Verify the Amount is valid for SEC code and TransactionCode
-		// if err := batch.ValidAmountForCodes(entry); err != nil { // TODO(adam): https://github.com/moov-io/ach/issues/1170
-		// 	return err
-		// }
+		// Verify the Amount is valid for SEC code and TransactionCode
+		if err := batch.ValidAmountForCodes(entry); err != nil {
+			return err
+		}
 		// Verify the TransactionCode is valid for a ServiceClassCode
 		if err := batch.ValidTranCodeForServiceClassCode(entry); err != nil {
 			return err