Add DeleteEntry and DeleteADVEntry to Batcher #1511
Merged
+87
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdecaf
approved these changes
Nov 21, 2024
|
Thinking about this more implementing them as DeleteFunc makes more sense. That lets callers control what is matched on to delete (and allows for deleting more than one entry) |
|
Sounds good - yeah that's how I was thinking. I will update it to add that. |
adamdecaf
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1509
Was also contemplating if it would be more useful to implement a
DeleteFuncas thesliceslibrary provides, then it's easier to delete from theEntriesslice based on arbitrary criteria instead of by maintaining or retrieving the pointer you want to delete. If that's preferable I can implement that.