Merge pull request dherault#687 from dnalborczyk/eslint

Eslint adjustments

.eslintignore

@@ -0,0 +1,4 @@
+manual_test_nodejs
+manual_test_python
+manual_test_ruby
+manual_test_websocket

.eslintrc.js

@@ -1,21 +1,21 @@
 const { env, platform } = process;
 
 const rules = {
-  semi: ["error", "always"],
-  "prefer-destructuring": "off",
-  "key-spacing": "off",
-  "guard-for-in": "off",
-  "no-restricted-syntax": "off",
-  "import/no-dynamic-require": "off",
+  'guard-for-in': 'off',
+  'import/no-dynamic-require': 'off',
+  'key-spacing': 'off',
+  'no-restricted-syntax': 'off',
+  'prefer-destructuring': 'off',
+  semi: ['error', 'always'],
 };
 
 // workaround for git + eslint line ending issue on Travis for Windows OS:
 // https://travis-ci.community/t/files-in-checkout-have-eol-changed-from-lf-to-crlf/349/2
-if (env.TRAVIS && platform === "win32") {
-  rules["linebreak-style"] = "off";
+if (env.TRAVIS && platform === 'win32') {
+  rules['linebreak-style'] = 'off';
 }
 
 module.exports = {
-  extends: "dherault",
+  extends: 'dherault',
   rules,
 };

package.json

@@ -6,7 +6,7 @@
   "main": "src/index.js",
   "scripts": {
     "test": "mocha test",
-    "lint": "eslint src/**/*.js test/**/*.js"
+    "lint": "eslint ."
   },
   "repository": {
     "type": "git",

test/.eslintrc.js

@@ -5,5 +5,8 @@ const rules = {
 };
 
 module.exports = {
+  'env': {
+    'mocha': true
+  },
   rules,
 };

test/unit/authCanExecuteResourceTest.js

@@ -1,4 +1,3 @@
-/* global describe context it */
 const { expect } = require('chai');
 const authCanExecuteResource = require('../../src/authCanExecuteResource');
 
@@ -137,6 +136,7 @@ describe('authCanExecuteResource', () => {
         const canExecute = authCanExecuteResource(policy, resourceTwo);
         expect(canExecute).to.eq(false);
       });
+
       context('and the Resource is an array', () => {
         it('returns false', () => {
           const policy = setup(
@@ -154,6 +154,7 @@ describe('authCanExecuteResource', () => {
           expect(canExecute).to.eq(false);
         });
       });
+
       context('and there is also an Allow statement', () => {
         it('returns false', () => {
           const policy = setup(

test/unit/authFunctionNameExtractorTest.js

@@ -1,4 +1,3 @@
-/* global describe context it */
 const { expect } = require('chai');
 const authFunctionNameExtractor = require('../../src/authFunctionNameExtractor');
 
@@ -79,6 +78,7 @@ describe('authFunctionNameExtractor', () => {
     context('authorizer is a string', () => {
       it('is a string anAuthorizerName', supportedAuthTest('anAuthorizerName', 'anAuthorizerName'));
     });
+
     context('authorizer is an object', () => {
       it('named anAuthorizerName', supportedAuthTest({ name : 'anAuthorizerName' }, 'anAuthorizerName'));
     });

test/unit/authMatchPolicyResourceTest.js

@@ -1,4 +1,3 @@
-/* global describe context it */
 const { expect } = require('chai');
 const authMatchPolicyResource = require('../../src/authMatchPolicyResource');
 

test/unit/createLambdaProxyContextTest.js

@@ -1,5 +1,3 @@
-/* global describe before context it */
-/* eslint-disable no-unused-expressions */
 const { expect } = require('chai');
 const RequestBuilder = require('../support/RequestBuilder');
 const createLambdaProxyContext = require('../../src/createLambdaProxyContext');

test/unit/functionHelperTest.js

@@ -1,4 +1,3 @@
-/* global describe before context it */
 const { expect } = require('chai');
 const path = require('path');
 const functionHelper = require('../../src/functionHelper');

test/unit/requestBodyValidatorTest.js

@@ -1,4 +1,3 @@
-/* global describe before context it */
 const { expect } = require('chai');
 const requestBodyValidator = require('../../src/requestBodyValidator');
 
@@ -64,13 +63,15 @@ describe('requestBodyValidator', () => {
           },
         },
       };
+
       before(() => {
         result = requestBodyValidator.getModel(custom, eventHttp, log => logStorage.push(log));
       });
 
       it('should return null', () => {
         expect(result).to.eq(null);
       });
+
       it('should add a warning log', () => {
         expect(logStorage.length).to.eq(1);
         expect(logStorage[0]).to.eq(`Warning: can't find '${anotherModel}' within ${JSON.stringify(eventHttp.documentation.requestModels)}`);
@@ -101,6 +102,7 @@ describe('requestBodyValidator', () => {
       const body = JSON.stringify({
         message: 'foo',
       });
+
       it('should throw error', () => {
         expect(() => requestBodyValidator.validate(model, body)).to.throw(/Request body validation failed.*/);
       });

test/unit/utilsTest.js

@@ -1,4 +1,3 @@
-/* global describe context it */
 const { expect } = require('chai');
 const {
   detectEncoding,

test/unit/velocityContextTest.js

@@ -1,4 +1,3 @@
-/* global describe it */
 const { expect } = require('chai');
 const createVelocityContext = require('../../src/createVelocityContext');