Fix some OAuth related issues

* Add logging for config issues * oauth callback expiration should be milliseconds not microseconds * Return on error early during oauth callback * Prevent no config from throwing exception constructing string
morganstanley · Jul 3, 2024 · 8f16e29 · 8f16e29
1 parent 15ee433
commit 8f16e29
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/include/kafka/ClientCommon.h b/include/kafka/ClientCommon.h
@@ -1,5 +1,6 @@
 #pragma once
 
+#include <chrono>
 #include <kafka/Project.h>
 
 #include <kafka/Error.h>
@@ -32,7 +33,7 @@ namespace KAFKA_API { namespace clients {
         using KeyValuePairs = std::map<std::string, std::string>;
 
         std::string               value;
-        std::chrono::microseconds mdLifetime{};
+        std::chrono::milliseconds mdLifetime{};
         std::string               mdPrincipalName;
         KeyValuePairs             extensions;
     };

diff --git a/include/kafka/KafkaClient.h b/include/kafka/KafkaClient.h
@@ -372,7 +372,7 @@ KafkaClient::KafkaClient(ClientType                     clientType,
         }
         else
         {
-            KAFKA_API_DO_LOG(Log::Level::Err, "failed to be initialized with property[%s:%s], result[%d]", k.c_str(), v->c_str(), result);
+            KAFKA_API_DO_LOG(Log::Level::Err, "failed to be initialized with property[%s:%s], result[%d]: %s", k.c_str(), v->c_str(), result, errInfo.c_str());
         }
     }
 
@@ -570,11 +570,12 @@ KafkaClient::oauthbearerTokenRefreshCallback(rd_kafka_t* rk, const char* oauthbe
 
     try
     {
-        oauthbearerToken = kafkaClient(rk).onOauthbearerTokenRefresh(oauthbearerConfig);
+        oauthbearerToken = kafkaClient(rk).onOauthbearerTokenRefresh(oauthbearerConfig != nullptr ? oauthbearerConfig : "");
     }
     catch (const std::exception& e)
     {
         rd_kafka_oauthbearer_set_token_failure(rk, e.what());
+        return;
     }
 
     LogBuffer<LOG_BUFFER_SIZE> errInfo;