Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[protocol review] Make revokeRoot onlyUpdater or remove revokeRoots #68

Closed
QGarchery opened this issue Oct 27, 2023 · 0 comments · Fixed by #83
Closed

[protocol review] Make revokeRoot onlyUpdater or remove revokeRoots #68

QGarchery opened this issue Oct 27, 2023 · 0 comments · Fixed by #83

Comments

@QGarchery
Copy link
Contributor

Updaters already have the power to revoke pending transactions throught the submitRoot function (with current values for example). If revokeRoots has upsides and we don’t want to remove it, then updaters could also benefit from those
@QGarchery QGarchery linked a pull request Nov 6, 2023 that will close this issue
Rename RootRevoked to PendingRootRevoked #83
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename RootRevoked to PendingRootRevoked morpho-org/universal-rewards-distributor
2 participants
@QGarchery @julien-devatom