Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing FA2 as a dependency as it is not actively maintained and does not pip install from PyPI on Python 3.9+ #104

Closed
dburkhardt opened this issue Feb 13, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@dburkhardt
Copy link
Contributor

dburkhardt commented Feb 13, 2023

Describe the bug
To reproduce

  1. Have Python 3.9.15
  2. Build scenicplus from source
  3. Install fails at fa2 dependency due to Problem installing fa2 on Python3.9 bhargavchippada/forceatlas2#34

Workaround:

  1. Build fa2 from source
  2. Build scenicplus from source

Error output
See bhargavchippada/forceatlas2#34

Additional context

@dburkhardt dburkhardt changed the title Consider removing FA2 as a dependency as it is not actively maintained and does not pip install from PyPI on Python 3.9+ #92 Consider removing FA2 as a dependency as it is not actively maintained and does not pip install from PyPI on Python 3.9+ Feb 13, 2023
@KenjiKamimoto-ac
Copy link
Member

@dburkhardt

Thank you for your feedback.
I'll look into it.

CellOracle is developed and tested with Python 3.8 and is not currently guaranteed for Python 3.9.
Can you please use python 3.8 for now? But we will test newer version of python including dependencies as soon as possible!

@KenjiKamimoto-ac KenjiKamimoto-ac added the enhancement New feature or request label Feb 13, 2023
@dburkhardt
Copy link
Contributor Author

dburkhardt commented Feb 13, 2023

Hi Kenji, thanks for the prompt response!

Where is fa2 used in the code base? I don't see it when I search.

Regarding 3.8, this is now an outdated release for Python. The current stable release is 3.9 and the latest release is 3.11. If this is the only thing keeping you using an outdated release, why not remove?

@KenjiKamimoto-ac
Copy link
Member

The force-directed graph is used in our tutorial preparing celloracle input data.

https://morris-lab.github.io/CellOracle.documentation/notebooks/03_scRNA-seq_data_preprocessing/scanpy_preprocessing_with_Paul_etal_2015_data.html

@dburkhardt
Copy link
Contributor Author

dburkhardt commented Feb 13, 2023

If it's just in the tutorial for pre-processing scRNA, why not just ask people to install it in the notebook like you do with the ATAC base-grn pre-processing tools cicero and monocle3?

It's not really required to use CellOracle, right? From what I can tell, this is the only thing keeping CellOracle from being compatible with the current stable Python release.

@KenjiKamimoto-ac
Copy link
Member

KenjiKamimoto-ac commented Feb 13, 2023

Yes, it is not CellOracle itself. The scRNA-seq data preparation step is a necessary step, and I've listed it on the celloracle requirements, but I can remove it and just recommend user to install fa manually.

The fa2 is not the reason why use python3.8. We are working hard to update the package, but it is always taking time to keep python's latest release. Can you please use python 3.8 for now? We will test the newer version of python, including dependencies, as soon as possible.
Do you have any problem with python3.8? Please let me know if you have another issue. It will help us improve codes!

@KenjiKamimoto-ac
Copy link
Member

KenjiKamimoto-ac commented Feb 13, 2023

@dburkhardt

For the celloracle next release, 0.10.16, I will remove fa2 from the requirements and
add instructions to install fa2 manually on the tutorial documentation.
That is a relatively easy task! (I already updated requirement file on github repo.)
I'm planning to release cellorace 0.10.16 next week on PyPI!

I think I still need to check some things to support python3.9 or later, but we will do it as soon as possible.

Sorry for the inconvenience! And thanks a lot for your feedback!

@dburkhardt
Copy link
Contributor Author

Great! For reference, I'm using CellOracle on Python 3.9.15 and it works fine.

KenjiKamimoto-ac added a commit that referenced this issue Feb 14, 2023
Update utility/requirements.txt - required for #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants