Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add sliding window warmup callback #1589

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions llmfoundry/callbacks/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@
)
from llmfoundry.callbacks.run_timeout_callback import RunTimeoutCallback
from llmfoundry.callbacks.scheduled_gc_callback import ScheduledGarbageCollector
from llmfoundry.callbacks.sliding_window_size_warmup_callback import \
SlidingWindowSizeWarmerUpper
from llmfoundry.registry import callbacks, callbacks_with_config

callbacks.register('system_metrics_monitor', func=SystemMetricsMonitor)
Expand Down Expand Up @@ -67,6 +69,10 @@
callbacks_with_config.register('async_eval', func=AsyncEval)
callbacks_with_config.register('curriculum_learning', func=CurriculumLearning)
callbacks_with_config.register('dataset_swap', func=DatasetSwap)
callbacks_with_config.register(
'sliding_window_size_warmer_upper',
func=SlidingWindowSizeWarmerUpper,
)

__all__ = [
'FDiffMetrics',
Expand All @@ -81,4 +87,5 @@
'CurriculumLearning',
'LossPerpVsContextLengthLogger',
'KillLossSpike',
'SlidingWindowSizeWarmerUpper',
]
69 changes: 69 additions & 0 deletions llmfoundry/callbacks/sliding_window_size_warmup_callback.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
# Copyright 2024 MosaicML LLM Foundry authors
# SPDX-License-Identifier: Apache-2.0

from typing import Any

from composer import Logger, State, TimeUnit

from llmfoundry.interfaces import CallbackWithConfig
from llmfoundry.utils.warnings import experimental_class

__all__ = [
'SlidingWindowSizeWarmerUpper',
]


@experimental_class('SlidingWindowSizeWarmerUpper')
class SlidingWindowSizeWarmerUpper(CallbackWithConfig):
"""Warms up the sliding window size for the model based on a schedule.

Args:
train_config (dict[str, Any]): Training configuration.
t_warmup (float): Warmup duration (as a fraction of max duration) for sliding window size.
"""

def __init__(
self,
train_config: dict[str, Any],
t_warmup: float,
):
self.t_warmup = t_warmup
self.max_seq_len = train_config['max_seq_len']
self.orig_sliding_window_size_list = None

def before_train_batch(self, state: State, logger: Logger):
del logger
if state.max_duration is None:
raise ValueError(
'SlidingWindowSizeWarmerUpper callback requires max_duration to be set.',
)
if state.max_duration.unit == TimeUnit.TOKEN:
current_time_frac = state.timestamp.token.value / state.max_duration.value
elif state.max_duration.unit == TimeUnit.BATCH:
current_time_frac = state.timestamp.batch.value / state.max_duration.value
else:
raise ValueError(
f'Unsupported time unit {state.max_duration.unit=} for SlidingWindowSizeWarmerUpper callback.',
)
if self.orig_sliding_window_size_list is None:
self.orig_sliding_window_size_list = [None] * len(
state.model.model.transformer.blocks,
)
for idx, block in enumerate(state.model.model.transformer.blocks):
attn_block = block.norm_attn_norm.attn if hasattr(
block,
'norm_attn_norm',
) else block.attn
if self.orig_sliding_window_size_list[idx] is None:
self.orig_sliding_window_size_list[
idx] = attn_block.sliding_window_size
if self.orig_sliding_window_size_list[idx] != -1: # type: ignore
attn_block.sliding_window_size = round(
max(
self.orig_sliding_window_size_list[idx],
self.max_seq_len - (
self.max_seq_len -
self.orig_sliding_window_size_list[idx]
) * current_time_frac / self.t_warmup,
),
)
Loading