New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Object store and packet writer implementation #13

Closed

anshulv1401 wants to merge 23 commits into mosip:develop from anshulv1401:develop

Contributor

anshulv1401 commented Jan 18, 2022 •

edited

Loading

#2 Port 'Packet Manager' and 'KeyManager' service to new repo
Added PosixImplementation :

Packets are stored in the location provided in config.properties key "objectstore.base.location".
Only supports external storage.
Added PackerWriterImplementation.
Currently support added to demographic and document dataset.

Pending things

Key manager integration for sign and encrypt.
Biometric XML serialization.

anshulv1401 and others added 16 commits

October 4, 2021 13:19


          General-PosixAdapter added

dedb7a1


          Object store Demo for addObjectMetaData added

6f0098f


          getObject method implemented

fa015b3


          General-Object store impl-Test for getmetadata, remove container, add…

af061ce

… tags, get tags added


          Object store updated

692307b


          Merge branch 'develop' of https://github.com/mosip/android-registrati…

64cfbda

…on-client into develop


          Latest code from upstream merged

b8ec5cf


          Code copied and implemented from ClientManager module to Packet Manag…

e090aa9

…er module


          lombok annotation added

366f941


          IPacketCryptoService interface added

394eb08


          Test for PackerWriter added

93aac4c


          Persist Packet test added

4e865e4


          Hardcoded values moved to configuration file

b8f50f4


          Update PacketCryptoServiceImpl.java

e4d4738


          DigestAsPlainText implemented.

0ecb9f1


          Base64 Url encoder corrected

ase-101 reviewed

View reviewed changes

client/clientmanager/src/main/java/io/mosip/registration/clientmanager/contant/QualityType.java Outdated

+              //@Data
+              //@NoArgsConstructor
+              //@AllArgsConstructor
+              public class QualityType implements Serializable {

Collaborator

ase-101 Feb 13, 2022

All the classes related to BIR should be part of packetmanager

ase-101 reviewed

View reviewed changes

client/clientmanager/src/main/java/io/mosip/registration/clientmanager/contant/PurposeType.java Outdated

+              //@XmlType(name = "PurposeType")
+              //@XmlEnum
+              public enum PurposeType implements Serializable {

Collaborator

ase-101 Feb 13, 2022

All the classes related to BIR should be part of packetmanager

ase-101 reviewed

View reviewed changes

...entmanager/src/main/java/io/mosip/registration/clientmanager/contant/ProcessedLevelType.java Outdated

+              //@XmlType(name = "ProcessedLevelType")
+              //@XmlEnum
+              public enum ProcessedLevelType implements Serializable {

Collaborator

ase-101 Feb 13, 2022

All the classes related to BIR should be part of packetmanager

ase-101 reviewed

View reviewed changes

...anager/src/main/java/io/mosip/registration/clientmanager/contant/PacketManagerConstants.java Outdated

		@@ -0,0 +1,117 @@
		package io.mosip.registration.clientmanager.contant;

		public class PacketManagerConstants {

Collaborator

ase-101 Feb 13, 2022

why is the packetManagerConstants added in clientmanager ?

ase-101 reviewed

View reviewed changes

...t/clientmanager/src/main/java/io/mosip/registration/clientmanager/contant/BiometricType.java Outdated

+              //@XmlType(name = "SingleTypeType")
+              //@XmlEnum
+              public enum BiometricType implements Serializable {

Collaborator

ase-101 Feb 13, 2022

All the classes related to BIR should be part of packetmanager

ase-101 reviewed

View reviewed changes

client/clientmanager/build.gradle

@@ @@ -28,6 +28,17 @@ android { @@
               }
               dependencies {
+                  implementation 'com.google.dagger:dagger:2.38.1'

Collaborator

ase-101 Feb 13, 2022

dagger, lombok are already added, please remove duplicates

ase-101 reviewed

View reviewed changes

...ntmanager/src/main/java/io/mosip/registration/clientmanager/dto/crypto/CryptoRequestDto.java

+              @Data
+              @AllArgsConstructor
+              @NoArgsConstructor
+              public class CryptoRequestDto {

Collaborator

ase-101 Feb 13, 2022

This DTO is already present in keymanager

ase-101 reviewed

View reviewed changes

...tmanager/src/main/java/io/mosip/registration/clientmanager/dto/crypto/CryptoResponseDto.java

+              @Data
+              @AllArgsConstructor
+              @NoArgsConstructor
+              public class CryptoResponseDto {

Collaborator

ase-101 Feb 13, 2022

This DTO is already present in keymanager

ase-101 reviewed

View reviewed changes

...anager/src/main/java/io/mosip/registration/clientmanager/dto/crypto/PublicKeyRequestDto.java

+              @AllArgsConstructor
+              @NoArgsConstructor
+              public class PublicKeyRequestDto {
+                  @NotBlank(message = "Invalid Request")

Collaborator

ase-101 Feb 13, 2022

This DTO is already present in keymanager

ase-101 reviewed

View reviewed changes

...nager/src/main/java/io/mosip/registration/clientmanager/dto/crypto/PublicKeyResponseDto.java

+              @Data
+              @AllArgsConstructor
+              @NoArgsConstructor
+              public class PublicKeyResponseDto {

Collaborator

ase-101 Feb 13, 2022

This DTO is already present in keymanager

ase-101 reviewed

View reviewed changes

...ientmanager/src/main/java/io/mosip/registration/clientmanager/dto/crypto/SignRequestDto.java

+              @Data
+              @AllArgsConstructor
+              @NoArgsConstructor
+              public class SignRequestDto {

Collaborator

ase-101 Feb 13, 2022

This DTO is already present in keymanager

ase-101 reviewed

View reviewed changes

...entmanager/src/main/java/io/mosip/registration/clientmanager/dto/crypto/SignResponseDto.java

+              @Data
+              @AllArgsConstructor
+              @NoArgsConstructor
+              public class SignResponseDto {

Collaborator

ase-101 Feb 13, 2022

This DTO is already present in keymanager

ase-101 reviewed

View reviewed changes

...nager/src/main/java/io/mosip/registration/clientmanager/dto/crypto/SignVerifyRequestDto.java

+              @Data
+              @AllArgsConstructor
+              @NoArgsConstructor
+              public class SignVerifyRequestDto {

Collaborator

ase-101 Feb 13, 2022

This DTO is already present in keymanager

ase-101 reviewed

View reviewed changes

...ager/src/main/java/io/mosip/registration/clientmanager/dto/crypto/SignVerifyResponseDto.java

+              @Data
+              @AllArgsConstructor
+              @NoArgsConstructor
+              public class SignVerifyResponseDto {

Collaborator

ase-101 Feb 13, 2022

This DTO is already present in keymanager

anshulv1401 added 5 commits

February 18, 2022 11:42


          Added Cbeff Implementation for XML serialization

c964f12


          Deleted Unused DTOs

79ff281


          Sign and encrypt integration methods added

78ea4ea


          unused Client Manager module deleted

b0eea56


          Revert "unused Client Manager module deleted"

93fcd38

This reverts commit b0eea56

anshulv1401 changed the title ~~Object store and packet writer implementation~~ #2 Object store and packet writer implementation


          Deleted duplicate packet manager DTOs and Classes from client Manager…

daa91b9

… module

anshulv1401 changed the title ~~#2 Object store and packet writer implementation~~ Object store and packet writer implementation


          Bug-Packet Writer-Persist Packet-Failing-Config file name corrected

9f0122e

Collaborator

ase-101 commented Mar 11, 2022

Different PR is raised for the same code changes.

ase-101 closed this

anshulv1401 deleted the develop branch

May 27, 2022 06:02

anshulv1401 restored the develop branch

May 27, 2022 06:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet