#2 Update KeyManagerService #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added android based testing. |
EricJohnEastwood
changed the title
ase-101
reviewed
Oct 5, 2021
...anager/src/main/java/io/mosip/registration/clientmanager/dto/crypto/PublicKeyRequestDto.java
Outdated
Show resolved
Hide resolved
ase-101
reviewed
Oct 5, 2021
...in/java/io/mosip/registration/clientmanager/service/crypto/LocalClientCryptoServiceImpl.java
Outdated
Show resolved
Hide resolved
ase-101
reviewed
Oct 5, 2021
| try { | ||
| String keyRequest = publicKeyRequestDto.getServerProfile(); | ||
| Log.i(TAG, "getPublicKey: Public key accessed for " + keyRequest); | ||
| if(keyRequest == "sign") { |
There was a problem hiding this comment.
Create a separate class to create these constants. and use static way of accessing this constants.
check this example - https://github.com/mosip/keymanager/blob/develop/kernel/kernel-keymanager-service/src/main/java/io/mosip/kernel/cryptomanager/constant/CryptomanagerConstant.java
and also error codes example from here - https://github.com/mosip/keymanager/blob/develop/kernel/kernel-keymanager-service/src/main/java/io/mosip/kernel/cryptomanager/constant/CryptomanagerErrorCode.java
|
This PR is part of #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added 2 separate keystore aliases for endec and sign
added separate key pair generation for endec and sign
symmetric key is now generated and used within encryption
fixed log messages
moved all property initialization to properties.config
updated UI
getPublicKey() provides either signing public key or encryption public key based on contents PublicKeyRequestDto