Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES-911] modified the readme file to add sunbird configuration #18

Merged
merged 5 commits into from
Apr 5, 2024

Conversation

kaifk468
Copy link
Contributor

…gnet

@@ -15,32 +15,27 @@ mosip.esignet.integration.key-binder=MockKeyBindingWrapperService
mosip.esignet.integration.audit-plugin=LoggerAuditService
mosip.esignet.integration.captcha-validator=GoogleRecaptchaValidatorService

## -------------------------------------------- IDP-UI config -----------------------------------------------------------------##
mosip.esignet.authenticator.default.auth-factor.kba.field-details={{'id':'policyNumber', 'type':'text', 'format':''},{'id':'name', 'type':'text', 'format':''},{'id':'dob', 'type':'date', 'format':'dd/mm/yyyy'}}
mosip.esignet.authenticator.default.auth-factor.kba.individual-id-field=policyNumber
Copy link

@ase-101 ase-101 Mar 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We donot have to separate above 2 properties. It can be part of "Sunbird-RC Plugin Configurations" section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

@ase-101 ase-101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls check the review comments

Mohd Kaif Siddique added 2 commits March 20, 2024 17:38
Signed-off-by: Mohd Kaif Siddique <[email protected]>
…l into readme.md file

Signed-off-by: Mohd Kaif Siddique <[email protected]>
@kaifk468 kaifk468 changed the title modified the readme file to add sunbird configuration [ES-911] modified the readme file to add sunbird configuration Mar 27, 2024
kaifk468 and others added 2 commits March 28, 2024 11:53
Signed-off-by: Kaif Siddique <[email protected]>
Signed-off-by: Mohd Kaif Siddique <[email protected]>
@vishwa-vyom vishwa-vyom merged commit 1d0359b into mosip:release-0.1.x Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants