Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INJIMOB-1862] Modifications in mdoc generation #73

Merged
merged 8 commits into from
Nov 5, 2024
Merged

[INJIMOB-1862] Modifications in mdoc generation #73

merged 8 commits into from
Nov 5, 2024

Conversation

KiruthikaJeyashankar
Copy link

@KiruthikaJeyashankar KiruthikaJeyashankar commented Oct 21, 2024 •
edited
Loading

changes for mso_mdoc VC:

  • replace hardcoded dates with realtime date
  • modify issuing country for vc verification check
  • x5chain of cose signature to contain only DS (Document Signer) certificate
  • fix to have same doctype in document & MSO
  • add id field for mdoc VC which holds random UUID

changes for ldp_vc:

  • replace hardcoded uuid with random UUID

@KiruthikaJeyashankar
[INJIMOB-1862] replace hardcoded dates with realtime date in mdoc gen…
e303d9a 
…eration

other changes:
modify issuing country for vc verification check

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar KiruthikaJeyashankar force-pushed the injimob-1862 branch 2 times, most recently from 432f36a to 03ca196 Compare October 21, 2024 06:58
@KiruthikaJeyashankar KiruthikaJeyashankar changed the title [INJIMOB-1862] replace hardcoded dates with realtime date in mdoc generation [INJIMOB-1862] Modifications in mdoc generation Oct 21, 2024
vharsh
vharsh approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@vharsh vharsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, try to add UTs if possible

@jainhitesh9998
Copy link
Contributor

Can you add unit test cases for Digital credential plugin targeting to your usecase?

@swatigoel swatigoel merged commit a437218 into mosip:develop Nov 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vharsh vharsh vharsh approved these changes

@jainhitesh9998 jainhitesh9998 jainhitesh9998 approved these changes

@swatigoel swatigoel swatigoel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KiruthikaJeyashankar @jainhitesh9998 @swatigoel @vharsh