Fix to saving entity

Signed-off-by: Loganathan Sekar <[email protected]>
mosip · Feb 9, 2024 · 60ababe · 60ababe
1 parent 60211ae
commit 60ababe
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/...n-common/src/main/java/io/mosip/authentication/common/service/integration/OTPManager.java b/...n-common/src/main/java/io/mosip/authentication/common/service/integration/OTPManager.java
@@ -109,7 +109,7 @@ public boolean sendOtp(OtpRequestDTO otpRequestDTO, String idvid, String idvidTy
 
 		if(otpEntityOpt.isPresent()) {
 			OtpTransaction otpEntity = otpEntityOpt.get();
-			requireOtpNotFrozen(otpEntity);
+			requireOtpNotFrozen(otpEntity, false);
 		}
 
 		String otp = generateOTP(otpRequestDTO.getIndividualId());
@@ -217,10 +217,9 @@ public boolean validateOtp(String pinValue, String otpKey, String individualId)
 		}
 
 		OtpTransaction otpEntity = otpEntityOpt.get();
-		requireOtpNotFrozen(otpEntity);
+		requireOtpNotFrozen(otpEntity, true);
 
 		if(otpEntity.getStatusCode().equals(IdAuthCommonConstants.UNFROZEN)) {
-			otpRepo.save(otpEntity);
 			throw new IdAuthenticationBusinessException(IdAuthenticationErrorConstants.OTP_REQUEST_REQUIRED);
 		}
 
@@ -257,13 +256,16 @@ public boolean validateOtp(String pinValue, String otpKey, String individualId)
 	 * @param otpEntity the otp entity
 	 * @throws IdAuthenticationBusinessException the id authentication business exception
 	 */
-	private void requireOtpNotFrozen(OtpTransaction otpEntity) throws IdAuthenticationBusinessException {
+	private void requireOtpNotFrozen(OtpTransaction otpEntity, boolean saveEntity) throws IdAuthenticationBusinessException {
 		if(otpEntity.getStatusCode().equals(IdAuthCommonConstants.FROZEN)) {
 			if(!isAfterFrozenDuration(otpEntity)) {
 				throw createOTPFrozenException();
 			}
 			logger.info("OTP Frozen wait time is over. Allowing further.");
 			otpEntity.setStatusCode(IdAuthCommonConstants.UNFROZEN);
+			if(saveEntity) {
+				otpRepo.save(otpEntity);
+			}
 		}
 	}