MOSIP-36579 Fixed sonar hotspot and bug (#1360)

* MOSIP-36579 Fixed sonar hotspot and bug Signed-off-by: kameshsr <[email protected]> * Corrected java version Signed-off-by: kameshsr <[email protected]> * MOSIP-36579 Added null check Signed-off-by: kameshsr <[email protected]> * MOSIP-36579 Added null check Signed-off-by: kameshsr <[email protected]> --------- Signed-off-by: kameshsr <[email protected]>
mosip · Oct 17, 2024 · 6cb7a85 · 6cb7a85
1 parent a43cfc7
commit 6cb7a85
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -10,7 +10,7 @@ This repository contains source code and design documents for MOSIP ID Authentic
 Refer to [SQL scripts](db_scripts).
 
 ## Build & run (for developers)
-The project requires JDK 1.11. 
+The project requires JDK 1.21. 
 1. Build and install:
     ```
     $ cd kernel

diff --git a/...on/src/main/java/io/mosip/authentication/common/service/integration/DataShareManager.java b/...on/src/main/java/io/mosip/authentication/common/service/integration/DataShareManager.java
@@ -55,8 +55,11 @@ public <R> R downloadObject(String dataShareUrl, Class<R> clazz, boolean decrypt
 		RestRequestDTO request = restRequestFactory.buildRequest(RestServicesConstants.DATA_SHARE_GET, null, String.class);
 		request.setUri(dataShareUrl);
 		String responseStr = restTemplate.getForObject(dataShareUrl, String.class);
+		if (responseStr == null) {
+			throw new IdAuthUncheckedException(IdAuthenticationErrorConstants.UNABLE_TO_PROCESS.getErrorCode(), IdAuthenticationErrorConstants.UNABLE_TO_PROCESS.getErrorMessage());
+		}
 		Optional<Entry<String, Object>> errorOpt = RestUtil.getError(responseStr, mapper);
-		
+
 		if (errorOpt.isEmpty()) {
 			R result;
 			if (decryptionRequired) {

diff --git a/...in/java/io/mosip/authentication/common/service/websub/impl/IdChangeEventsInitializer.java b/...in/java/io/mosip/authentication/common/service/websub/impl/IdChangeEventsInitializer.java
@@ -89,7 +89,6 @@ private void subscribeForCredentialIssueanceEvents(String topicPrefix) {
 				webSubHelper.subscribe(subscriptionRequest);
 				logger.info(IdAuthCommonConstants.SESSION_ID, "subscribeForCredentialIssueanceEvents", "", "Subscribed to topic: " + topic);
 			} catch (Exception e) {
-				e.printStackTrace();
 				logger.info(IdAuthCommonConstants.SESSION_ID, "subscribeForCredentialIssueanceEvents",  e.getClass().toString(), "Error subscribing topic: "+ topic +"\n" + e.getMessage());
 				throw e;
 			}