Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOSIP-31982] Enabling and disabling kafka bean #1250

Merged
merged 17 commits into from
Apr 18, 2024

Conversation

Neha2365
Copy link
Contributor

No description provided.

Neha2365 and others added 17 commits April 4, 2024 13:00
Signed-off-by: Neha Farheen <[email protected]>
Co-authored-by: Neha Farheen <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Co-authored-by: Neha Farheen <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
Signed-off-by: Neha Farheen <[email protected]>
@loganathan-sekaran loganathan-sekaran merged commit 0d42ffc into mosip:release-1.2.1.x Apr 18, 2024
8 checks passed
@vishwa-vyom
Copy link
Member

@Neha2365 I checked on the PR, look ok except for one point
we are check for bean null and taking the decision to notify or not
but what if the bean was null for other reasons ?
should we rather check with the configuration directly ?
and have a postconstruct to check if the config is true and the bean is null and throw an error
this is because we have told required is false in autowire and I am assuming it will not hinder the startup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants