Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1304

Merged
merged 12 commits into from
Sep 2, 2024
Merged

Develop #1304

merged 12 commits into from
Sep 2, 2024

Conversation

Anuranjan14
Copy link

No description provided.

Signed-off-by: Anuranjan14 <120705365+Anuranjan14@users.noreply.github.com>
Signed-off-by: Anuranjan14 <120705365+Anuranjan14@users.noreply.github.com>
Signed-off-by: Anuranjan14 <120705365+Anuranjan14@users.noreply.github.com>
Signed-off-by: Anuranjan14 <120705365+Anuranjan14@users.noreply.github.com>
Copy link
Member

@Sohandey Sohandey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct this testcase
:
apitest/src/main/resources/ida/UpdateDraft/UpdateDraft.yml

Signed-off-by: Anuranjan14 <120705365+Anuranjan14@users.noreply.github.com>
Signed-off-by: Anuranjan14 <120705365+Anuranjan14@users.noreply.github.com>
Copy link

@lsivanand lsivanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't have secret key values in the kernel properties.. Values should be empty

@ckm007 ckm007 merged commit ed60381 into mosip:develop Sep 2, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants