Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INJICERT-585] refactor VC Sign algo impl & add Ed25519Signature2020 #128

Merged
merged 6 commits into from
Nov 13, 2024
Merged

[INJICERT-585] refactor VC Sign algo impl & add Ed25519Signature2020 #128

merged 6 commits into from
Nov 13, 2024

Conversation

vharsh
Copy link
Member

@vharsh vharsh commented Nov 5, 2024 •
edited
Loading

High level code changes

  • Implement Strategy pattern for VC Signing using different LD Signing Algorithms such as RsaSignature2018, Ed25519Signature2018, Ed25519Signature2020.
  • VCSigner interface no longer needs props from CertifyIssuanceServiceImpl.

High level feature changes

  • Ed25519Signature2020 has also been implemented and any future LD Sign Algorithms can be implemented more easily going forward. While this is implemented, it's use should be avoided for now till Keymanager or supplementary VC signing library is implemented
  • Keymanager version got bumped up to add support for Ed25519Signature2020 via SignatureServiceV2.signv2(SignRequestDtoV2 s)

@vharsh vharsh marked this pull request as ready for review November 6, 2024 10:17
@vharsh vharsh requested a review from jainhitesh9998 November 7, 2024 09:29
@vharsh
[INJICERT-585] refactor proof signing
3a802cd 
move SignatureServiceX calls to ProofStrategy

Signed-off-by: Harsh Vardhan <[email protected]>
@vharsh
Copy link
Member Author

vharsh commented Nov 12, 2024

The above build is failing because keymanager JAR push has failed for this PR and DevOps team might have to take a look into this.

@vharsh
[INJICERT-585] bump up keymanager version
02289db 
* add support for Ed25519-2020 signing to keymanager

Signed-off-by: Harsh Vardhan <[email protected]>
@jainhitesh9998 jainhitesh9998 merged commit 57bb461 into mosip:develop Nov 13, 2024
9 of 10 checks passed
@vharsh vharsh deleted the ed25519-2020 branch December 20, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jainhitesh9998 jainhitesh9998 jainhitesh9998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vharsh @jainhitesh9998