Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unnecessary logs added as part of debugging #568

Closed
Alka1703 opened this issue Feb 17, 2023 · 1 comment
Closed

Cleanup unnecessary logs added as part of debugging #568

Alka1703 opened this issue Feb 17, 2023 · 1 comment
Labels
beta_must_fix BLE BLE Transefer of VCs BLE-Sharing Related to BLE sharing mechanism enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet

Comments

@Alka1703
Copy link
Contributor

Alka1703 commented Feb 17, 2023 •
edited by ravikp
Loading

To improve the speed of transfer, remove the debug logs that print large amount of VC data. Below tasks needed to be addressed:

  1. Remove logs added to print SHA for each data chunk in both iOS and android side.
  2. Remove logs to print the complete encrypted VC data for both iOS and android side.
  3. Remove logs printing any encryption key in both iOS and Android side.
  4. Change all print statements to OS_logs in iOS side.
@Alka1703 Alka1703 added enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet labels Feb 17, 2023
@ravikp ravikp added beta_must_fix BLE BLE Transefer of VCs BLE-Sharing Related to BLE sharing mechanism labels Feb 21, 2023
This was referenced Feb 28, 2023
Merged
Merged
@Alka1703
Copy link
Contributor Author

The following PRs implement removal of unnecessary logs and printing SHA of data both on android and iOS side. It also changes all print statements to os_logs on iOS side.
PR for mosip/tuvali: #28
PR for mosip/inji: #595, #597

The PRs have been merged in 28-02-2023 Release and the latest commit id on mosip/inji/develop is 7cdee82

@ravikp ravikp closed this as completed Mar 1, 2023
@github-project-automation github-project-automation bot moved this from Closed to Merged in MOSIP Inji issues tracking Mar 1, 2023
@Sujithbn Sujithbn moved this from Merged to Closed in MOSIP Inji issues tracking Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beta_must_fix BLE BLE Transefer of VCs BLE-Sharing Related to BLE sharing mechanism enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet
Projects
MOSIP Inji issues tracking
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ravikp @krishnakumar4a4 @Alka1703