-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android & IOS stability Release build #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d as part of debugging
…ame from class itself
… to avoid exception Signed-off-by: Alka Prasad <[email protected]>
…n report to avoid exception" This reverts commit ac0fa19.
… to avoid exception Signed-off-by: Alka Prasad <[email protected]>
…allback in time Signed-off-by: Alka Prasad <[email protected]>
- fix write with response method - add permissions to transfer report request char on Android and IOS side - fix didWriteValue callback when there is error
#576 : Refactor Log tags.
* chore: remove unused walletViewModel from swift * chore: add BackOffStrategy to project config
…plete Destroy connection on transfer complete
chore(#576) : refactor log tag in android
… in transfer handler
feat(#543): retry for TransferReport from iOS and request it reliably
#568 : cleanup unnecessary logs
…to avoid re-requesting report Signed-off-by: Alka Prasad <[email protected]>
Revert "#568 : cleanup unnecessary logs"
* refactor(#568): [Adityan] [Android|iOS] cleanup unnecessary logs added as part of debugging --------- Co-authored-by: Adityan Kannan <[email protected]>
Signed-off-by: Alka Prasad <[email protected]>
ravikp
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
This was referenced Feb 28, 2023
vharsh
pushed a commit
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements as part of this release:
Defects: