Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Tuvali commit or tag information in Profile screen #576

Closed
krishnakumar4a4 opened this issue Feb 21, 2023 · 3 comments
Closed

Show Tuvali commit or tag information in Profile screen #576

krishnakumar4a4 opened this issue Feb 21, 2023 · 3 comments
Labels
BLE BLE Transefer of VCs BLE-Sharing Related to BLE sharing mechanism enhancement New feature or request P3 Minor task Non functional tasks triage This issue is pending confirmation and planning and should not be worked on yet
Milestone
24th Feb 23

Comments

@krishnakumar4a4
Copy link
Contributor

krishnakumar4a4 commented Feb 21, 2023 •
edited
Loading

What to do

  • Show Tuvali version on Profile screen
  • Add commit/tag information in Tuvali logs [Android Only]
@krishnakumar4a4 krishnakumar4a4 added enhancement New feature or request triage This issue is pending confirmation and planning and should not be worked on yet labels Feb 21, 2023
@ravikp ravikp added task Non functional tasks BLE BLE Transefer of VCs P3 Minor BLE-Sharing Related to BLE sharing mechanism labels Feb 21, 2023
@krishnakumar4a4 krishnakumar4a4 changed the title Show commit or tag information in logs Show Tuvali commit or tag information in logs Feb 23, 2023
@krishnakumar4a4 krishnakumar4a4 mentioned this issue Feb 24, 2023
Merged
krishnakumar4a4 added a commit to tw-mosip/inji-wallet that referenced this issue Feb 24, 2023
@krishnakumar4a4
Merge pull request #2 from ravikp/display-tuvali-commit-hash
bc9f0d8 
feat(mosip#576): Display Tuvali version details on App Profile section
@shreeThaanuTw shreeThaanuTw mentioned this issue Feb 24, 2023
Merged
PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Feb 24, 2023
@PuBHARGAVI
fix(mosip#576): [Bhargavi|Adityan] add conditions to display tuvali v…
d811ae4 
…ersion in profilescreen
This was referenced Feb 24, 2023
Merged
Merged
@Sujithbn Sujithbn added this to the 24th Feb 23 milestone Feb 24, 2023
@Alka1703
Copy link
Contributor

Alka1703 commented Feb 24, 2023 •
edited
Loading

The following PRs implement displaying the latest commit id and version tag information on profile screen both on android and iOS devices. It also displays the tag information in the logs of android.
PR for mosip/tuvali: mosip/tuvali#26
PR for mosip/inji:#584

The PRs have been merged in 24-02-2023 Release and the latest commit id on mosip/inji/develop is cb47493

@krishnakumar4a4 krishnakumar4a4 changed the title Show Tuvali commit or tag information in logs Show Tuvali commit or tag information in Profile screen Feb 24, 2023
@krishnakumar4a4 krishnakumar4a4 moved this from Development to Closed in MOSIP Inji issues tracking Feb 24, 2023
@krishnakumar4a4 krishnakumar4a4 removed their assignment Feb 24, 2023
This was referenced Feb 28, 2023
Merged
Merged
@Alka1703
Copy link
Contributor

Alka1703 commented Feb 28, 2023 •
edited
Loading

The following PRs implements displays the tag information along with class name in the logs of android.
PR for mosip/tuvali: #28
PR for mosip/inji: #595, #597

The PRs have been merged in 28-02-2023 Release and the latest commit id on mosip/inji/develop is 7cdee82

@ravikp ravikp closed this as completed Mar 1, 2023
@github-project-automation github-project-automation bot moved this from Closed to Merged in MOSIP Inji issues tracking Mar 1, 2023
@Sujithbn Sujithbn moved this from Merged to Closed in MOSIP Inji issues tracking Mar 10, 2023
@Kratitva
Copy link

This is fixed as part of release v0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BLE BLE Transefer of VCs BLE-Sharing Related to BLE sharing mechanism enhancement New feature or request P3 Minor task Non functional tasks triage This issue is pending confirmation and planning and should not be worked on yet
Projects
MOSIP Inji issues tracking
Status: Closed
Milestone
24th Feb 23
Development

No branches or pull requests
5 participants
@ravikp @krishnakumar4a4 @Alka1703 @Sujithbn @Kratitva