Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the labels for buttons to "Share" and "Share with Selfie" in credential share screen #589

Closed
nayakrounak opened this issue Feb 27, 2023 · 5 comments
Closed

Update the labels for buttons to "Share" and "Share with Selfie" in credential share screen #589

nayakrounak opened this issue Feb 27, 2023 · 5 comments
Assignees
@Sujithbn
Labels
enhancement New feature or request good first issue Good for newcomers MEC targeted for MEC task Non functional tasks triage This issue is pending confirmation and planning and should not be worked on yet
Milestone
28th Feb 23

Comments

@nayakrounak
Copy link

Describe the bug
The labels in the credential share screen need to be modified.

  • "Accept request and choose ID" to "Share"
  • "Accept request and verify" to "Share with Selfie"

Pre-requisite
The application should have at least one credential to share.

To Reproduce
Steps to reproduce the behaviour:

  1. Open the application
  2. Click on the QR code scanner
  3. Scan the verifier QR code to connect with the verifier application
  4. Share credential screen is shown below

Expected behaviour
The labels for sharing credentials buttons need to be modified.

  • "Accept request and choose ID" to "Share"
  • "Accept request and verify" to "Share with Selfie"

Screenshots

image

Smartphone (please complete the following information):

Not Applicable

Additional context
Enhancement as discussed with Sasi on 24th Feb 2023.
@nayakrounak nayakrounak added bug Something isn't working triage This issue is pending confirmation and planning and should not be worked on yet labels Feb 27, 2023
@Sujithbn Sujithbn added the good first issue Good for newcomers label Feb 27, 2023
@Sujithbn Sujithbn added BLE BLE Transefer of VCs task Non functional tasks MEC targeted for MEC and removed BLE BLE Transefer of VCs bug Something isn't working labels Feb 27, 2023
PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Feb 27, 2023
@PuBHARGAVI
refactor(mosip#589): [Bhargavi|Vijay] change sharing vc labels
3c4d351
@PuBHARGAVI
Copy link
Contributor

Labels are changed to "share" and "share with Selfie" in english language.
Translation for other languages required apart from english

ravikp added a commit to tw-mosip/inji-wallet that referenced this issue Feb 27, 2023
@ravikp
Merge pull request #4 from ravikp/change-sharing-vc-labels
d1fa352 
refactor(mosip#589): [Bhargavi|Vijay] change sharing vc labels
@tilak-puli tilak-puli mentioned this issue Feb 28, 2023
Merged
ravikp added a commit that referenced this issue Feb 28, 2023
@ravikp
Merge pull request #595 from ravikp/develop
452bc3e 
Include Feb/28/2023 release - Inji Changes

* Change VC button labels #589 
* Auto select first VC #590 
* Remove activate button for received VC's #512
@ravikp ravikp added the enhancement New feature or request label Feb 28, 2023
@ravikp
Copy link
Contributor

ravikp commented Feb 28, 2023

Issue merged in the PR - #595

@Sujithbn Sujithbn added this to the 28th Feb 23 milestone Feb 28, 2023
@ravikp ravikp moved this to Development in MOSIP Inji issues tracking Feb 28, 2023
@Sujithbn Sujithbn moved this from Development to QA (test) in MOSIP Inji issues tracking Feb 28, 2023
@Alka1703
Copy link
Contributor

The following PRs implements text change on the button labels on the consent page:

  • "Accept request and choose ID" to "Share"
  • "Accept request and verify" to "Share with Selfie"

PR for mosip/tuvali: #28
PR for mosip/inji: #595, #597

The PRs have been merged in 28-02-2023 Release and the latest commit id on mosip/inji/develop is 7cdee82

PuBHARGAVI added a commit to tw-mosip/inji-wallet that referenced this issue Mar 9, 2023
@PuBHARGAVI
refactor(mosip#589): [Bhargavi] change sharing vc labels to share and…
ec379e7 
… share with selfie in all languages
@adityankannan-tw adityankannan-tw mentioned this issue Mar 21, 2023
Closed
@damodarguru
Copy link

damodarguru commented Mar 21, 2023 •
edited
Loading

Verify the task in new build, The changes are reflecting as expected. Attaching the screenshots for reference.

Screenshots:
image
image
image
image
image
image
image
image
image

Verified in: -
Device: iPhone 8
OS:16.0.2
BLE version: 5.0
Inji app version:0.4.1 (29) -> TestFlight

Device: Redmi K20 Pro
Android Version: 11
BLE version :5.0
Inji app link: https://github.com/mosip/inji/actions/runs/4447486079
Mimoto version: 1.2.0.1
MOSIP Version: qa-1201-b2.mosip.net

@github-project-automation github-project-automation bot moved this from QA (test) to Merged in MOSIP Inji issues tracking Mar 23, 2023
@Kratitva
Copy link

This is fixed as part of release v0.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sujithbn Sujithbn

Labels
enhancement New feature or request good first issue Good for newcomers MEC targeted for MEC task Non functional tasks triage This issue is pending confirmation and planning and should not be worked on yet
Projects
MOSIP Inji issues tracking
Status: Merged
Milestone
28th Feb 23
Development

No branches or pull requests
10 participants
@ravikp @krishnakumar4a4 @Alka1703 @nayakrounak @PuBHARGAVI @Anushree09-N @Raginikrishnamurthy @Sujithbn @damodarguru @Kratitva