-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: (Inji-261): Most of the elements which are still in orange in the purple theme are fixed. #1021
Merged
swatigoel
merged 5 commits into
mosip:develop
from
tw-mosip:inji-261-elements-still-in-orange-in-the-purple-theme
Nov 20, 2023
Merged
Fix: (Inji-261): Most of the elements which are still in orange in the purple theme are fixed. #1021
swatigoel
merged 5 commits into
mosip:develop
from
tw-mosip:inji-261-elements-still-in-orange-in-the-purple-theme
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rple theme Signed-off-by: anil_majji <[email protected]>
…ple theme Signed-off-by: anil_majji <[email protected]>
Signed-off-by: anil_majji <[email protected]>
vijay151096
reviewed
Nov 17, 2023
vijay151096
reviewed
Nov 17, 2023
vijay151096
reviewed
Nov 17, 2023
vijay151096
reviewed
Nov 17, 2023
vijay151096
reviewed
Nov 17, 2023
vijay151096
reviewed
Nov 17, 2023
Signed-off-by: anil_majji <[email protected]>
swatigoel
reviewed
Nov 20, 2023
Signed-off-by: anil_majji <[email protected]>
swatigoel
approved these changes
Nov 20, 2023
PuBHARGAVI
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Nov 21, 2023
…e purple theme are fixed. (mosip#1021) * Feat(INJI-261): Some elements still appearing orange colour in the purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Some elements still appearing orange colour in the purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the home screen icons to purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the comments of respective PR Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the comments of respective PR Signed-off-by: anil_majji <[email protected]> --------- Signed-off-by: anil_majji <[email protected]> Signed-off-by: PuBHARGAVI <[email protected]>
srikanth716
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Nov 23, 2023
…e purple theme are fixed. (mosip#1021) * Feat(INJI-261): Some elements still appearing orange colour in the purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Some elements still appearing orange colour in the purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the home screen icons to purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the comments of respective PR Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the comments of respective PR Signed-off-by: anil_majji <[email protected]> --------- Signed-off-by: anil_majji <[email protected]>
swatigoel
pushed a commit
that referenced
this pull request
Nov 30, 2023
* feat(INJI-474): show popup for invalid QR (#999) * feat(INJI-474): show popup for invalid QR * at times a scanned QR code is neither online nor offline Co-authored-by: adityankannan-tw <[email protected]> Signed-off-by: Harsh Vardhan <[email protected]> * refactor(INJI-474): add a dismiss-able popup w buttons Signed-off-by: Harsh Vardhan <[email protected]> * feat(INJI-474): use polyfill for URL searchParams feat Signed-off-by: Harsh Vardhan <[email protected]> * feat(INJI-474): move popup buttons to a single row Signed-off-by: Harsh Vardhan <[email protected]> * refactor(INJI-474): align buttons in popup Co-authored-by: Anil kumar M <[email protected]> Signed-off-by: Harsh Vardhan <[email protected]> * feat(INJI-474): don't show Loader on invalidQR & fix QR type logic Signed-off-by: Harsh Vardhan <[email protected]> * refactor(INJI-474): propagate btn style changes to Themes Co-authored-by: Vijay <[email protected]> Signed-off-by: Harsh Vardhan <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]> Co-authored-by: Harsh Vardhan <[email protected]> Co-authored-by: Anil kumar M <[email protected]> Co-authored-by: Vijay <[email protected]> * Fix: (Inji-261): Most of the elements which are still in orange in the purple theme are fixed. (#1021) * Feat(INJI-261): Some elements still appearing orange colour in the purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Some elements still appearing orange colour in the purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the home screen icons to purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the comments of respective PR Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the comments of respective PR Signed-off-by: anil_majji <[email protected]> --------- Signed-off-by: anil_majji <[email protected]> * MOSIP-30340 | Regression test for IOS added (#1023) * Test script updated for new apk Signed-off-by: kamalsingh <[email protected]> * new test cases added Signed-off-by: kamalsingh <[email protected]> * new test cases added from master sheet Signed-off-by: kamalsingh <[email protected]> * Test cases added from regression sheet Signed-off-by: kamalsingh <[email protected]> * new test cases added Signed-off-by: kamalsingh <[email protected]> * automated ios tests for regression Signed-off-by: kamalsingh <[email protected]> * conflict resolved Signed-off-by: kamalsingh <[email protected]> --------- Signed-off-by: kamalsingh <[email protected]> * Credential Registry testcases, help page new test cases added , MOSIP-30054 MOSIP-30230 MOSIP-30282 (#1024) * MOSIP-30054 MOSIP-30230 MOSIP-30282 Signed-off-by: Anup Nehe <[email protected]> * resolve conflicts Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> * resolve conflict Signed-off-by: Anup Nehe <[email protected]> --------- Signed-off-by: Anup Nehe <[email protected]> * fix(INJI-536):check status failed while downloading vc (#1032) Signed-off-by: Sri Kanth Kola <[email protected]> * refactor(INJI-449): replace crypto-js with node-forge for encryption/decryption (#1034) * refactor(INJI-449): replace crypo-js with node-forge crypto-js has vulneraribitiles prior to version 4.2.0 for encryption / decryption & 4.x.x version is not compatible with our react native project For this reason we had to move to different library for encryption / decryption Co-authored-by: Sreenadh S <[email protected]> Signed-off-by: Kiruthika Jeyashankar <[email protected]> * fix(INJI-449): secure-keystore warning popup shown on reload of app settings key which was stored in storage was not loaded into settings machine context correctly, which caused the bug - on reload settings related flows was falling back to initial setting. Co-authored-by: Sreenadh S <[email protected]> Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): gitignore automation test results Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): simplify usage of methods in node-forge Signed-off-by: Kiruthika Jeyashankar <[email protected]> --------- Signed-off-by: Kiruthika Jeyashankar <[email protected]> Co-authored-by: Sreenadh S <[email protected]> * refactor(INJI-449): fix OWASP vulnerabilities with dependencies (#1035) * refactor(INJI-449): remove unused dependencies Dependencies removed 1. expo-status-bar 2. @expo-google-fonts/poppins 3. react-native-simple-markdown 4. react-native-swipe-gestures DevDependencies removed 1. @react-native/metro-config (removed as we already have @expo/metro-config dependency used) 2. metro-react-native-babel-preset 3. @types/react-test-renderer 4. react-test-renderer Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): update expo related packages and crypto-js Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): update transitive dependency of expo-updates package plist package is a transitive dependency of expo-updates which had vulnerability - Prototype pollution vulnerability via .parse() in Plist before v3.0.4 allows attackers to cause a Denial of Service (DoS) and may lead to remote code execution. Thus this package was updated to fix vulnerability Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): update axios dependency of telemetry-sdk to 1.6.0 Since the package axios(1.5.0) has vulnerability - Cross-Site Request Forgery (CSRF), it is updated to 1.6.0 Signed-off-by: Kiruthika Jeyashankar <[email protected]> * fix(INJI-449): vulnerablity issue with @digitalbazaar/rsa-verification-key-2018 override the node-forge dependency of the package - @digitalbazaar/rsa-verification-key-2018 as it has the high severity with CVE count 13 Signed-off-by: Kiruthika Jeyashankar <[email protected]> * revert(INJI-449): downgrade crypto-js to 3.3.0 from 4.x.x version Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): use expo-splash-screen instead of expo-app-loading expo-app-loading package is deprecated and it is suggested to replace it with expo-splash-screen Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): optimize time taken to hide splash screen Co-authored-by: Sreenadh S <[email protected]> Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): change appEntry to index js Change appEntry to index.js file since react-native-url-polyfill/auto is imported to avoid URL error. appEntry is required for expo package update Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-559): update podfile.lock Signed-off-by: Kiruthika Jeyashankar <[email protected]> * refactor(INJI-449): optimize import Signed-off-by: Kiruthika Jeyashankar <[email protected]> --------- Signed-off-by: Kiruthika Jeyashankar <[email protected]> * feat(INJI-541): for sonar qube generate dummy release keystore file in build.gradle Signed-off-by: PuBHARGAVI <[email protected]> * fix(INJI-541): pass sonar args as input variable in internal build yml file Signed-off-by: PuBHARGAVI <[email protected]> * fix(INJI-541): use dummy alias and password for dummyrelease keystore Signed-off-by: PuBHARGAVI <[email protected]> * MOSIP-30369 | Framework structure change to support device farm execution (#1039) * Test script updated for new apk Signed-off-by: kamalsingh <[email protected]> * new test cases added Signed-off-by: kamalsingh <[email protected]> * new test cases added from master sheet Signed-off-by: kamalsingh <[email protected]> * Test cases added from regression sheet Signed-off-by: kamalsingh <[email protected]> * new test cases added Signed-off-by: kamalsingh <[email protected]> * automated ios tests for regression Signed-off-by: kamalsingh <[email protected]> * conflict resolved Signed-off-by: kamalsingh <[email protected]> * framework optimization Signed-off-by: kamalsingh <[email protected]> * folder structure changed Signed-off-by: kamalsingh <[email protected]> * framework restructure for device farm Signed-off-by: kamalsingh <[email protected]> * incorporated review comments Signed-off-by: kamalsingh <[email protected]> --------- Signed-off-by: kamalsingh <[email protected]> * fix(INJI-541): comment sonarqube check Signed-off-by: adityankannan-tw <[email protected]> * fix(INJI-541): use correct env variable name for slack webhook url Signed-off-by: adityankannan-tw <[email protected]> --------- Signed-off-by: Harsh Vardhan <[email protected]> Signed-off-by: anil_majji <[email protected]> Signed-off-by: kamalsingh <[email protected]> Signed-off-by: Anup Nehe <[email protected]> Signed-off-by: Sri Kanth Kola <[email protected]> Signed-off-by: Kiruthika Jeyashankar <[email protected]> Signed-off-by: PuBHARGAVI <[email protected]> Signed-off-by: adityankannan-tw <[email protected]> Co-authored-by: Harsh Vardhan <[email protected]> Co-authored-by: Anil kumar M <[email protected]> Co-authored-by: Vijay <[email protected]> Co-authored-by: kamalsinghthoughtworks <[email protected]> Co-authored-by: anup-nehe <[email protected]> Co-authored-by: srikanth716 <[email protected]> Co-authored-by: KiruthikaJeyashankar <[email protected]> Co-authored-by: Sreenadh S <[email protected]> Co-authored-by: PuBHARGAVI <[email protected]> Co-authored-by: adityankannan-tw <[email protected]>
vharsh
pushed a commit
to tw-mosip/inji-wallet
that referenced
this pull request
Dec 1, 2023
…e purple theme are fixed. (mosip#1021) * Feat(INJI-261): Some elements still appearing orange colour in the purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Some elements still appearing orange colour in the purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the home screen icons to purple theme Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the comments of respective PR Signed-off-by: anil_majji <[email protected]> * FIX(INJI-261): Fixed the comments of respective PR Signed-off-by: anil_majji <[email protected]> --------- Signed-off-by: anil_majji <[email protected]> Signed-off-by: Harsh Vardhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INJI-261:- There are few elements still in orange in the purple theme.