Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Injimob 1540] enhancements for liveness detection in face verification flow #1562

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

[Injimob 1540] enhancements for liveness detection in face verification flow #1562

wants to merge 8 commits into from

Conversation

PuBHARGAVI
Copy link
Contributor

@PuBHARGAVI PuBHARGAVI commented Jul 15, 2024 •
edited by jira bot
Loading

Description

This PR has the below enhancements for the Liveness Detection in face verification flow:

  • Oval shape is removed from the Face scanner in the UI.
  • Max number of times the user can retry the face verification if it is fails is set to 3 and UI message and translations are updated for the success and failure messages as per the wireframes.
  • Added logic to remove used images from the application's cache in order to minimize the amount of space taken up by the images and prevent application crashes.

Issue ticket number and link

INJIMOB-1540

PuBHARGAVI added 8 commits July 2, 2024 17:46
@PuBHARGAVI
[INJIMOB-1540] don't show oval shape in the face scanner and remove u…
995be9c 
…nused imports

Signed-off-by: PuBHARGAVI <[email protected]>
@PuBHARGAVI
[INJIMOB-1540] change the liveness detection error screen header and …
4f41a6b 
…subHeader messages in all locale files

Signed-off-by: PuBHARGAVI <[email protected]>
@PuBHARGAVI
[INJIMOB-1540] show proper message when multiple faces are detected a…
5455acb 
…nd add translations for the same

Signed-off-by: PuBHARGAVI <[email protected]>
@PuBHARGAVI
[INJIMOB-1540] allow user to retry face liveness detection max of 3 t…
2ab3829 
…imes

Signed-off-by: PuBHARGAVI <[email protected]>
@PuBHARGAVI
[INJIMOB-1540] add translations for liveness detection failure messag…
57a59ba 
…es in all locale files

Signed-off-by: PuBHARGAVI <[email protected]>
@PuBHARGAVI
[INJIMOB-1540] show liveness capture guide message when new frame cap…
e9b90a6 
…ture is started and until the face is detected and remove translations for oval shape message

Signed-off-by: PuBHARGAVI <[email protected]>
@PuBHARGAVI
[INJIMOB-1540] remove captured or cropped images from cache after usi…
87fa085 
…ng them

Signed-off-by: PuBHARGAVI <[email protected]>
@PuBHARGAVI
[INJIMOB-1540] rename cropEyeFromFace method to validateLiveness and …
07e8cee 
…extract logic of it into separate individual methods for more readability

Signed-off-by: PuBHARGAVI <[email protected]>
sree96
sree96 requested changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@sree96 sree96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz provide inputs for the comment

@PuBHARGAVI PuBHARGAVI marked this pull request as draft July 30, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sree96 sree96 sree96 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PuBHARGAVI @sree96