Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INJIMOB-2415] show credential type in mini view instead of fullName #1720

Merged
merged 24 commits into from
Nov 29, 2024
Merged

[INJIMOB-2415] show credential type in mini view instead of fullName #1720

merged 24 commits into from
Nov 29, 2024

Conversation

KiruthikaJeyashankar
Copy link
Contributor

KiruthikaJeyashankar and others added 24 commits November 29, 2024 16:26
@KiruthikaJeyashankar
[INJIMOB-2415] show credential type in mini view
14b095e 
Previously, it was showing hardcoded fullName in mini view

Other changes include
- Handling of display property
  -> unavailable in wellknown
  -> empty array in wellknown
  -> expected credential type (name) is not available in display property of wellknown

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] rename getIDType to getCredentialType
7acb780 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@Alka1703 @KiruthikaJeyashankar
[INJIMOB-2415]: update logic to get credential type
db1855a 
Signed-off-by: Alka Prasad <[email protected]>
@Alka1703 @KiruthikaJeyashankar
[INJIMOB-2415]: update the translation for mso mdoc fallback for cred…
def6cbb 
…ential type

Signed-off-by: Alka Prasad <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] update getCredentialType method comments
1df8377 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2369] remove commented code
952024b 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] get backgroundColor of VC from curr lang's display pro…
a717ebc 
…perty

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] get background image of VC from curr lang's display pr…
d9d7e6d 
…operty

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] get text color of VC from curr lang's display property
528f95c 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] add prop types for VCVerification component
61adce3 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] introduce fieldColor prop in VCItemField for VC mini &…
a43d0b1 
… detail view

As of now, for each and every field that is getting rendered we are calling getTextColor with wellknown param, if we start bringing in logic of getDisplayObjectForCurrentLanguage and then get the text_color from it, we will end up in running a filter for each and every field. For reducing this complexity, VCItemField component is accepting fieldColor prop from the caller.

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] move fallback miniview kebab popup color to const
f7fd99e 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] move fallback detailview border color to const
cf53b5e 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] move fallback verification text color to const
7d5fe97 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] remove unnecessary sending of props
52865e6 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] refactor type error
c88c5b2 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] refactor type error
6b58d48 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] refactor - remove unused prop
7ab190a 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] refactor getBackgroundColor to accept display element …
9065cea 
…as per app languange

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] refactor getBackgroundImage to accept display element …
65bce18 
…as per app languange

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] refactor getTextColor to accept display element as per…
8be1823 
… app languange

Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] fix credential type to be shown based on app lang
3d8478b 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] extract card's display related functions to class
da2eb47 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar
[INJIMOB-2415] fix build fail for accessing Theme in static block
6fee33a 
Signed-off-by: KiruthikaJeyashankar <[email protected]>
@KiruthikaJeyashankar KiruthikaJeyashankar marked this pull request as ready for review November 29, 2024 12:01
@swatigoel swatigoel merged commit fd9ce41 into mosip:release-0.15.x Nov 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatigoel swatigoel swatigoel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KiruthikaJeyashankar @swatigoel @Alka1703