[INJIMOB-2471] set UUID as vc identifier #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were relying on the id feild of the Vc to construct the unique identifier for VC component and file name for storing VC, this identifier in now replaced with random generated UUID. This was made since id property of VC is optional field as per w3c data-model 1.1. We are using UUID version 4 to ensure randomness and collision-resistance. Signed-off-by: KiruthikaJeyashankar <[email protected]>
Signed-off-by: KiruthikaJeyashankar <[email protected]>
This VC key will be used for storing file name, component key & other identifier for VCs Signed-off-by: KiruthikaJeyashankar <[email protected]>
The identitifier in credentialWrapper having the value "$issuer:$protocol:$UUID" was used to construct VC metadata id, issuer and protocol field which is already available in context param. This is now replaced with constructing VC metadata with the required fields available in machine context. Signed-off-by: KiruthikaJeyashankar <[email protected]>
… accessing in issuersMachine Signed-off-by: KiruthikaJeyashankar <[email protected]>
Signed-off-by: KiruthikaJeyashankar <[email protected]>
KiruthikaJeyashankar
force-pushed
the
injimob-2471-set-uuid-as-vc-identifier
branch
from
2f37986 to
de38181
Compare
swatigoel
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, credential ID was used as a unique identifier of the VC in the wallet. But as per spec credential ID field is optional, to remove this dependency, Wallet will use a generated UUID as the unique identifier for the VC. A UUID is generated on download which serves as identifier
VC id = ${UUID}_${issuer}Issue ticket number and link
Note: Tested VC download, Activation, QR login, backup / restore, share scenarios for sanity